Use named quries and input variables instead of creating query strings
Use gql documents instead of strings
Resolves T4554
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Maniphest Tasks
- T4554: GraphQL: Improve functional tests using GQL
- Commits
- rDGQL0f2eaba90f94: Refactor functional tests
No logic or test changes.
Diff Detail
Diff Detail
- Repository
- rDGQL GraphQL API
- Branch
- gql
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 32114 Build 50281: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 50280: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D8629 (id=31149)
Rebasing onto 6e1c3e8ecf...
Current branch diff-target is up to date.
Changes applied before test
commit 6e4b33ecbe08923139deeebe13447f86389b43db
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date: Wed Oct 5 10:31:20 2022 +0200
Refactor functional tests
Use named quries and input variables instead of creating query strings
Use gql documents instead of strings
Resolves T4554See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/212/ for more details.
Comment Actions
nice!
Have you considered switching to **kwargs instead of a single variables argument? I should make calls shorter (saves quotes and variables=)
Comment Actions
Build is green
Patch application report for D8629 (id=31150)
Rebasing onto 6e1c3e8ecf...
Current branch diff-target is up to date.
Changes applied before test
commit 0f2eaba90f947a688044fc6a9aef54dea2bbdd93
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date: Wed Oct 5 10:31:20 2022 +0200
Refactor functional tests
Use named quries and input variables instead of creating query strings
Use gql documents instead of strings
Resolves T4554See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/213/ for more details.