Paths

Table of Contentst

Differential D8557

Cpan: Cpan loader loads Perl modules from cpan.org
ClosedPublic
Actions

Authored by franckbret on Sep 28 2022, 9:41 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2833: cpan.loader - archive Perl modules from CPAN

Commits

rDLDBASE2db1a754e368: Cpan: Cpan loader loads Perl modules from cpan.org

Summary

For each origin it calls an http api endpoint to retrieve extrinsic
metadata for each version of a module.
Author and package description are extracted from intrinsic metadata
parsing data from META.json or META.yml at the root of the archive.

Related T2833

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

cpan

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31882
Build 49896: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49895: arc lint + arc unit

Event Timeline

franckbret created this revision.Sep 28 2022, 9:41 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 28 2022, 9:41 AM

Build is green

Patch application report for D8557 (id=30870)

Rebasing onto 798f749e66...

Current branch diff-target is up to date.

Changes applied before test

commit d0517a06abf44764f42995b9ba227bcab0e8d894
Author: Franck Bret <franck.bret@octobus.net>
Date:   Wed Sep 28 09:34:25 2022 +0200

    Cpan: Cpan loader loads Perl modules from cpan.org
    
    For each origin it calls an http api endpoint to retrieve extrinsic
    metadata for each version of a module.
    Author and package description are extracted from intrinsic metadata
    parsing data from META.json or META.yml at the root of the archive.
    
    Related T2833

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/901/ for more details.

Harbormaster completed remote builds in B31843: Diff 30870.Sep 28 2022, 9:45 AM

franckbret requested review of this revision.Sep 28 2022, 9:45 AM

vlorentz requested changes to this revision.Sep 28 2022, 10:31 AM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/loader/package/cpan/loader.py
39–40	why `str` instead of `datetime`? The loader parses it anyway
55	you forgot to change that
85–86	why this method?
90–91
141	Could you add a comment to mention this defaults to UTC, as the API does not provide an explicit timezone?
167	Could you assert the name is the same that was passed to the loader? If not, you should check the name does not contain any whitespace, as it would mess with the release message

This revision now requires changes to proceed.Sep 28 2022, 10:31 AM

Some improvments after review

Build is green

Patch application report for D8557 (id=30909)

Rebasing onto 798f749e66...

Current branch diff-target is up to date.

Changes applied before test

commit 173cf79917e3d225a0d70dae149c5c7faddb8b08
Author: Franck Bret <franck.bret@octobus.net>
Date:   Wed Sep 28 09:34:25 2022 +0200

    Cpan: Cpan loader loads Perl modules from cpan.org
    
    For each origin it calls an http api endpoint to retrieve extrinsic
    metadata for each version of a module.
    Author and package description are extracted from intrinsic metadata
    parsing data from META.json or META.yml at the root of the archive.
    
    Related T2833

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/904/ for more details.

Harbormaster completed remote builds in B31882: Diff 30909.Sep 28 2022, 5:31 PM

vlorentz accepted this revision.Sep 29 2022, 3:00 PM

This revision is now accepted and ready to land.Sep 29 2022, 3:00 PM

Rebase

This revision was landed with ongoing or failed builds.Sep 29 2022, 3:17 PM

Closed by commit rDLDBASE2db1a754e368: Cpan: Cpan loader loads Perl modules from cpan.org (authored by franckbret). · Explain Why

This revision was automatically updated to reflect the committed changes.

franckbret added a commit: rDLDBASE2db1a754e368: Cpan: Cpan loader loads Perl modules from cpan.org.

Build is green

Patch application report for D8557 (id=30949)

Rebasing onto 7375a83c2f...

Current branch diff-target is up to date.

Changes applied before test

commit 2db1a754e3686b8a66b64e8be2ac9ddf0aabe704
Author: Franck Bret <franck.bret@octobus.net>
Date:   Wed Sep 28 09:34:25 2022 +0200

    Cpan: Cpan loader loads Perl modules from cpan.org
    
    For each origin it calls an http api endpoint to retrieve extrinsic
    metadata for each version of a module.
    Author and package description are extracted from intrinsic metadata
    parsing data from META.json or META.yml at the root of the archive.
    
    Related T2833

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/912/ for more details.

Harbormaster completed remote builds in B31921: Diff 30949.Sep 29 2022, 3:19 PM

bchauvet added a task: T2833: cpan.loader - archive Perl modules from CPAN.Sep 30 2022, 9:13 AM