Paths

Table of Contentst

Differential D8378

Move static assets source code in related django application folders
ClosedPublic
Actions

Authored by anlambert on Sep 1 2022, 5:26 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T4398: Create one django application for each webapp feature

Commits

rDWAPPSc52158a8d7de: Move static assets source code in related django application folders

Summary

For each swh-web django application, create an assets folder in application
one and move related static assets source code (js, css, ...) in it.

Also modify webpack configuration to generate bundles the following way:

if swh/web/<app>/assets/index.js exists, a bundle named <app> is generated
if swh/web/<app>/assets/<bundle>/index.js exists, a bundle named <bundle> is generated

After these changes, some bundles got renamed but also new ones are generated
so update django templates and js code accordingly.

Related to T4398

Diff Detail

Repository

rDWAPPS Web applications

Branch

django-apps-refactoring-assets

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31338
Build 49024: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49023: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 1 2022, 5:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 1 2022, 5:26 PM

Build is green

Patch application report for D8378 (id=30236)

Rebasing onto 3c4ffa9198...

Current branch diff-target is up to date.

Changes applied before test

commit 74a0ab8e86042baba284ec3cea8e561930cfec49
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 1 17:07:02 2022 +0200

    Move static assets source code in related django application folders
    
    For each swh-web django application, create an assets folder in application
    one and move related static assets source code (js, css, ...) in it.
    
    Also modify webpack configuration to generate bundles the following way:
    
      - if swh/web/<app>/assets/index.js exists, a bundle named <app> is generated
    
      - if swh/web/<app>/assets/<bundle>/index.js exists, a bundle named <bundle>
        is generated
    
    After these changes, some bundles got renamed but also new ones are generated
    so update django templates and js code accordingly.
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2031/ for more details.

Harbormaster completed remote builds in B31275: Diff 30236.Sep 1 2022, 5:35 PM

anlambert requested review of this revision.Sep 1 2022, 5:35 PM

anlambert edited the summary of this revision. (Show Details)Sep 5 2022, 5:21 PM

Rebase

Build is green

Patch application report for D8378 (id=30306)

Rebasing onto 687b4bbddd...

Current branch diff-target is up to date.

Changes applied before test

commit 61852382a8814f32fc300795b07580ce8508f7c0
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 1 17:07:02 2022 +0200

    Move static assets source code in related django application folders
    
    For each swh-web django application, create an assets folder in application
    one and move related static assets source code (js, css, ...) in it.
    
    Also modify webpack configuration to generate bundles the following way:
    
      - if swh/web/<app>/assets/index.js exists, a bundle named <app> is generated
    
      - if swh/web/<app>/assets/<bundle>/index.js exists, a bundle named <bundle>
        is generated
    
    After these changes, some bundles got renamed but also new ones are generated
    so update django templates and js code accordingly.
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2037/ for more details.

Harbormaster completed remote builds in B31338: Diff 30306.Sep 6 2022, 11:09 AM

Build is green

Patch application report for D8378 (id=30306)

Rebasing onto 687b4bbddd...

Current branch diff-target is up to date.

Changes applied before test

commit 61852382a8814f32fc300795b07580ce8508f7c0
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 1 17:07:02 2022 +0200

    Move static assets source code in related django application folders
    
    For each swh-web django application, create an assets folder in application
    one and move related static assets source code (js, css, ...) in it.
    
    Also modify webpack configuration to generate bundles the following way:
    
      - if swh/web/<app>/assets/index.js exists, a bundle named <app> is generated
    
      - if swh/web/<app>/assets/<bundle>/index.js exists, a bundle named <bundle>
        is generated
    
    After these changes, some bundles got renamed but also new ones are generated
    so update django templates and js code accordingly.
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2038/ for more details.

Build is green

Patch application report for D8378 (id=30306)

Rebasing onto 687b4bbddd...

Current branch diff-target is up to date.

Changes applied before test

commit 61852382a8814f32fc300795b07580ce8508f7c0
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 1 17:07:02 2022 +0200

    Move static assets source code in related django application folders
    
    For each swh-web django application, create an assets folder in application
    one and move related static assets source code (js, css, ...) in it.
    
    Also modify webpack configuration to generate bundles the following way:
    
      - if swh/web/<app>/assets/index.js exists, a bundle named <app> is generated
    
      - if swh/web/<app>/assets/<bundle>/index.js exists, a bundle named <bundle>
        is generated
    
    After these changes, some bundles got renamed but also new ones are generated
    so update django templates and js code accordingly.
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2039/ for more details.

Build is green

Patch application report for D8378 (id=30306)

Rebasing onto 687b4bbddd...

Current branch diff-target is up to date.

Changes applied before test

commit 61852382a8814f32fc300795b07580ce8508f7c0
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 1 17:07:02 2022 +0200

    Move static assets source code in related django application folders
    
    For each swh-web django application, create an assets folder in application
    one and move related static assets source code (js, css, ...) in it.
    
    Also modify webpack configuration to generate bundles the following way:
    
      - if swh/web/<app>/assets/index.js exists, a bundle named <app> is generated
    
      - if swh/web/<app>/assets/<bundle>/index.js exists, a bundle named <bundle>
        is generated
    
    After these changes, some bundles got renamed but also new ones are generated
    so update django templates and js code accordingly.
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2040/ for more details.

Build is green

Patch application report for D8378 (id=30306)

Rebasing onto 687b4bbddd...

Current branch diff-target is up to date.

Changes applied before test

commit 61852382a8814f32fc300795b07580ce8508f7c0
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 1 17:07:02 2022 +0200

    Move static assets source code in related django application folders
    
    For each swh-web django application, create an assets folder in application
    one and move related static assets source code (js, css, ...) in it.
    
    Also modify webpack configuration to generate bundles the following way:
    
      - if swh/web/<app>/assets/index.js exists, a bundle named <app> is generated
    
      - if swh/web/<app>/assets/<bundle>/index.js exists, a bundle named <bundle>
        is generated
    
    After these changes, some bundles got renamed but also new ones are generated
    so update django templates and js code accordingly.
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2042/ for more details.

Build is green

Patch application report for D8378 (id=30306)

Rebasing onto 687b4bbddd...

Current branch diff-target is up to date.

Changes applied before test

commit 61852382a8814f32fc300795b07580ce8508f7c0
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 1 17:07:02 2022 +0200

    Move static assets source code in related django application folders
    
    For each swh-web django application, create an assets folder in application
    one and move related static assets source code (js, css, ...) in it.
    
    Also modify webpack configuration to generate bundles the following way:
    
      - if swh/web/<app>/assets/index.js exists, a bundle named <app> is generated
    
      - if swh/web/<app>/assets/<bundle>/index.js exists, a bundle named <bundle>
        is generated
    
    After these changes, some bundles got renamed but also new ones are generated
    so update django templates and js code accordingly.
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2041/ for more details.

Rebase

Build is green

Patch application report for D8378 (id=30348)

Rebasing onto 33212c44d3...

Current branch diff-target is up to date.

Changes applied before test

commit c52158a8d7de5f469d961838a4d503b98679085f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 1 17:07:02 2022 +0200

    Move static assets source code in related django application folders
    
    For each swh-web django application, create an assets folder in application
    one and move related static assets source code (js, css, ...) in it.
    
    Also modify webpack configuration to generate bundles the following way:
    
      - if swh/web/<app>/assets/index.js exists, a bundle named <app> is generated
    
      - if swh/web/<app>/assets/<bundle>/index.js exists, a bundle named <bundle>
        is generated
    
    After these changes, some bundles got renamed but also new ones are generated
    so update django templates and js code accordingly.
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2043/ for more details.

Harbormaster completed remote builds in B31376: Diff 30348.Sep 7 2022, 2:50 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2022, 3:07 PM

Closed by commit rDWAPPSc52158a8d7de: Move static assets source code in related django application folders (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSc52158a8d7de: Move static assets source code in related django application folders.