Call an http api endpoint per package to get all its versions and
artifacts metadata.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Maniphest Tasks
- T4465: Ingest pub.dev (Dart, Flutter)
- Commits
- rDLDBASEaa26fbd98ef8: PubDev, loads from pub.dev registry (Dart, FLutter)
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- pubdev
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 31084 Build 48633: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 48632: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D8305 (id=29980)
Rebasing onto 9f8bdceed1...
Current branch diff-target is up to date.
Changes applied before test
commit f4df224834e999053809af450a80bafa48f1f5bf
Author: Franck Bret <franck.bret@octobus.net>
Date: Wed Aug 24 13:24:46 2022 +0200
[WIP] PubDev, loads from pub.dev registry (Dart, FLutter)
Call an http api endpoint per package to get all its versions and
artifacts metadata.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/833/ for more details.
| swh/loader/package/pubdev/loader.py | ||
|---|---|---|
| 74 | Is this decorator useful here? | |
| 133–136 | https://dart.dev/tools/pub/pubspec#authorauthors describes an "authors". Does this API have it too? If yes, read it too and if there is more than one, use the first and ignore others (they will be part of metadata anyway) | |
| 162–165 | https://dart.dev/tools/pub/pubspec#authorauthors says the intrinsic author field is deprecated (and definitely should not take precedence over the one returned by the API) | |
Comment Actions
Build is green
Patch application report for D8305 (id=29989)
Rebasing onto 9f8bdceed1...
Current branch diff-target is up to date.
Changes applied before test
commit da6552b4fad581e96d287916f730163118eb8d93
Author: Franck Bret <franck.bret@octobus.net>
Date: Wed Aug 24 13:24:46 2022 +0200
PubDev, loads from pub.dev registry (Dart, FLutter)
Call an http api endpoint per package to get all its versions and
artifacts metadata.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/836/ for more details.
Comment Actions
Testing authors and empty author
Add tests and data fixtures to ensure we manage the case where a list of authors exists and the one where author is empty
Comment Actions
Build is green
Patch application report for D8305 (id=30022)
Rebasing onto 9f8bdceed1...
Current branch diff-target is up to date.
Changes applied before test
commit 5f9895cc6749f0d8bfc83d35b998119ef275c5e4
Author: Franck Bret <franck.bret@octobus.net>
Date: Wed Aug 24 13:24:46 2022 +0200
PubDev, loads from pub.dev registry (Dart, FLutter)
Call an http api endpoint per package to get all its versions and
artifacts metadata.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/839/ for more details.
Comment Actions
Build is green
Patch application report for D8305 (id=30023)
Rebasing onto 9f8bdceed1...
Current branch diff-target is up to date.
Changes applied before test
commit 1a948a534f82d2a46eef535786171b5a8fc0b018
Author: Franck Bret <franck.bret@octobus.net>
Date: Wed Aug 24 13:24:46 2022 +0200
PubDev, loads from pub.dev registry (Dart, FLutter)
Call an http api endpoint per package to get all its versions and
artifacts metadata.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/840/ for more details.
Comment Actions
Remove filename from release name
Using filename for building the release name was useless because there cannot be more than one file per version
Comment Actions
Build is green
Patch application report for D8305 (id=30035)
Rebasing onto 9f8bdceed1...
Current branch diff-target is up to date.
Changes applied before test
commit 700bdc2f3cb113f5281e97400074aa7d690c8bb3
Author: Franck Bret <franck.bret@octobus.net>
Date: Wed Aug 24 13:24:46 2022 +0200
PubDev, loads from pub.dev registry (Dart, FLutter)
Call an http api endpoint per package to get all its versions and
artifacts metadata.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/841/ for more details.
Comment Actions
Thanks, looks good.
One last thing: could you find smaller alternative for the test files? These are quite big, especially packages_pdf_versions_3.8.2.tar.gz
Comment Actions
Add a fake_pubdev.sh script that generate fake http api response and fake package archives for test purpose
Comment Actions
Build is green
Patch application report for D8305 (id=30049)
Rebasing onto 9f8bdceed1...
Current branch diff-target is up to date.
Changes applied before test
commit aa26fbd98ef8cfbec92a69ccde4ae1d799ff7d52
Author: Franck Bret <franck.bret@octobus.net>
Date: Wed Aug 24 13:24:46 2022 +0200
PubDev, loads from pub.dev registry (Dart, FLutter)
Call an http api endpoint per package to get all its versions and
artifacts metadata.See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/842/ for more details.