Page MenuHomeSoftware Heritage

DirectoryIndexer: Remove incorrect assumption on object types
ClosedPublic

Authored by vlorentz on Jun 28 2022, 12:31 PM.

Details

Summary

process_journal_objects can in theory be called from a journal client
which consumes other object types too, so there may be other objects,
and 'directory' may be missing entirely.

This isn't an issue in practice though, because DirectoryIndexer is
only used indirectly.

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30060
Build 46995: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 46994: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8043 (id=28970)

Rebasing onto bbf9dc8047...

Current branch diff-target is up to date.
Changes applied before test
commit 0babe56756068a3447c57f8a249f1837a2c127a4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 28 12:30:40 2022 +0200

    DirectoryIndexer: Remove incorrect assumption on object types
    
    process_journal_objects can in theory be called from a journal client
    which consumes other object types too, so there may be other objects,
    and 'directory' may be missing entirely.
    
    This isn't an issue in practice though, because DirectoryIndexer is
    only used indirectly.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/278/ for more details.

Build is green

Patch application report for D8043 (id=28972)

Rebasing onto bbf9dc8047...

Current branch diff-target is up to date.
Changes applied before test
commit 3394dca40599a5e2049bb68e7d0cfa94c417fb18
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jun 28 12:30:40 2022 +0200

    DirectoryIndexer: Remove incorrect assumption on object types
    
    process_journal_objects can in theory be called from a journal client
    which consumes other object types too, so there may be other objects,
    and 'directory' may be missing entirely.
    
    This isn't an issue in practice though, because DirectoryIndexer is
    only used indirectly.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/279/ for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 29 2022, 10:25 AM
This revision was automatically updated to reflect the committed changes.