Differential D7761

common/utils: Display seconds by default in format_utc_iso_date
ClosedPublic
Actions

Authored by anlambert on May 6 2022, 4:52 PM.

Details

Reviewers

jayeshv

Group Reviewers

Reviewers

Commits

rDWAPPS84fd757cf897: common/utils: Display seconds by default in format_utc_iso_date

Summary

It enables to disambiguate some dates in the Web UI (release ones for
instance) only differing by the number of seconds.

Diff Detail

Repository

rDWAPPS Web applications

Branch

date-display-seconds

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29151
Build 45576: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45575: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	42,077 ms	Jenkins > should close calendar popover when leaving day::Tests / Cypress tests / Run cypress tests / Visits tests should close calendar popover when leaving day AssertionError: Timed out retrying after 20000ms: expected '<div.popover-body>' to contain '14:57 UTC' at searchInCalendar (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-visits.spec.js:122:144) at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-visits.spec.js:159:7)
	21,260 ms	Jenkins > should display first full visit time::Tests / Cypress tests / Run cypress tests / Visits tests should display first full visit time AssertionError: Timed out retrying after 20000ms: expected '<div.popover-body>' to contain '14:57 UTC' at searchInCalendar (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-visits.spec.js:122:144) at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-visits.spec.js:135:7)
	21,333 ms	Jenkins > should display last full visit time::Tests / Cypress tests / Run cypress tests / Visits tests should display last full visit time AssertionError: Timed out retrying after 20000ms: expected '<div.popover-body>' to contain '14:57 UTC' at searchInCalendar (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-visits.spec.js:122:144) at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-visits.spec.js:141:7)
	21,340 ms	Jenkins > should display last visit time::Tests / Cypress tests / Run cypress tests / Visits tests should display last visit time AssertionError: Timed out retrying after 20000ms: expected '<div.popover-body>' to contain '14:57 UTC' at searchInCalendar (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-visits.spec.js:122:144) at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-visits.spec.js:147:7)
	21,743 ms	Jenkins > should display list of visits and mark them on calendar::Tests / Cypress tests / Run cypress tests / Visits tests should display list of visits and mark them on calendar AssertionError: Timed out retrying after 20000ms: expected '<div.popover-body>' to contain '14:57 UTC' at searchInCalendar (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-visits.spec.js:122:144) at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-visits.spec.js:153:7)
		View Full Test Results (5 Failed · 928 Passed · 5 Skipped)

Event Timeline

anlambert created this revision.May 6 2022, 4:52 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 6 2022, 4:52 PM

Build was aborted

Patch application report for D7761 (id=28079)

Rebasing onto e6a8303eef...

Current branch diff-target is up to date.

Changes applied before test

commit 263146f125df515d2d5766da7270070a21f9b673
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri May 6 16:38:37 2022 +0200

    common/utils: Display seconds by default in format_utc_iso_date
    
    It enables to disambiguate some dates in the Web UI (release ones for
    instance) only differing by the number of seconds.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1798/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1798/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 6 2022, 5:20 PM

Harbormaster failed remote builds in B29151: Diff 28079!

Fix cypress tests

Build is green

Patch application report for D7761 (id=28132)

Rebasing onto b30dc0510f...

Current branch diff-target is up to date.

Changes applied before test

commit 3dd52373624050dd866a676c3d3502338530c181
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri May 6 16:38:37 2022 +0200

    common/utils: Display seconds by default in format_utc_iso_date
    
    It enables to disambiguate some dates in the Web UI (release ones for
    instance) only differing by the number of seconds.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1807/ for more details.

Harbormaster completed remote builds in B29199: Diff 28132.May 9 2022, 5:17 PM

anlambert requested review of this revision.May 9 2022, 5:17 PM

LGTM

This revision is now accepted and ready to land.May 9 2022, 5:19 PM

Rebase

Build is green

Patch application report for D7761 (id=28163)

Rebasing onto b084e4b15e...

Current branch diff-target is up to date.

Changes applied before test

commit 84fd757cf897382d0eb1617d25af510a34258003
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri May 6 16:38:37 2022 +0200

    common/utils: Display seconds by default in format_utc_iso_date
    
    It enables to disambiguate some dates in the Web UI (release ones for
    instance) only differing by the number of seconds.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1811/ for more details.

Harbormaster completed remote builds in B29229: Diff 28163.May 10 2022, 11:28 AM

Closed by commit rDWAPPS84fd757cf897: common/utils: Display seconds by default in format_utc_iso_date (authored by anlambert). · Explain WhyMay 10 2022, 11:53 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS84fd757cf897: common/utils: Display seconds by default in format_utc_iso_date.