Page MenuHomeSoftware Heritage
Differential D7751

Add `algos.identifier.identifiers_missing`
Changes PlannedPublicDraft
Actions

Authored by Ericson2314 on May 5 2022, 8:13 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

This is a small wrapper around the underlying *_missing functions in
order to assist with looking up missing SWHIDs.

This will be a building block to clean up some things in swh-web so that
https://forge.softwareheritage.org/T4224 doesn't come back.

Diff Detail

Repository
rDSTO Storage manager
Branch
identifiers-missing (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 29102
Build 45499: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 45498: arc lint + arc unit

Event Timeline

Ericson2314 created this revision.May 5 2022, 8:13 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMay 5 2022, 8:13 PM
Ericson2314 updated this revision to Diff 28026.May 5 2022, 8:15 PM

Fix spelling error

swh-public-ci added a comment.May 5 2022, 8:15 PM

Build has FAILED

Patch application report for D7751 (id=28025)

Rebasing onto 9562953493...

Current branch diff-target is up to date.
Changes applied before test
commit 31d4c3e4cfee780a1e3c823ef132e216705d8704
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date:   Thu May 5 13:25:57 2022 -0400

    Add `algos.identifier.identifiers_missing`
    
    This is a small wrapper around the underlying `*_missing` functions in
    order to assist with looking up missing SWHIDs.
    
    This will be a building block to clean up some things in swh-web so that
    https://forge.softwareheritage.org/T4224 doesn't come back.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1605/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1605/console

Harbormaster failed remote builds in B29101: Diff 28025!May 5 2022, 8:15 PM
swh-public-ci added a comment.May 5 2022, 8:16 PM

Build has FAILED

Patch application report for D7751 (id=28026)

Rebasing onto 9562953493...

Current branch diff-target is up to date.
Changes applied before test
commit 026af46d2e36b5c40309ad1a1c13549167c2ff2e
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date:   Thu May 5 13:25:57 2022 -0400

    Add `algos.identifier.identifiers_missing`
    
    Summary:
    This is a small wrapper around the underlying `*_missing` functions in
    order to assist with looking up missing SWHIDs.
    
    This will be a building block to clean up some things in swh-web so that
    https://forge.softwareheritage.org/T4224 doesn't come back.
    
    Reviewers: #reviewers
    
    Differential Revision: https://forge.softwareheritage.org/D7751

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1606/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1606/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 5 2022, 8:16 PM
Harbormaster failed remote builds in B29102: Diff 28026!
Ericson2314 updated this revision to Diff 28027.May 5 2022, 8:19 PM

Ensure thre is an error on invalid object type

Condense / deduplicate to the code too in the process.

swh-public-ci added a comment.May 5 2022, 8:30 PM

Build has FAILED

Patch application report for D7751 (id=28027)

Rebasing onto 9562953493...

Current branch diff-target is up to date.
Changes applied before test
commit a92cef818b5a2b947f2cf733283c3f28116a2797
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date:   Thu May 5 13:25:57 2022 -0400

    Add `algos.identifier.identifiers_missing`
    
    Summary:
    This is a small wrapper around the underlying `*_missing` functions in
    order to assist with looking up missing SWHIDs.
    
    This will be a building block to clean up some things in swh-web so that
    https://forge.softwareheritage.org/T4224 doesn't come back.
    
    Reviewers: #reviewers
    
    Differential Revision: https://forge.softwareheritage.org/D7751

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1607/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1607/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 5 2022, 8:30 PM
Harbormaster failed remote builds in B29103: Diff 28027!
Ericson2314 updated this revision to Diff 28028.May 5 2022, 8:38 PM

Need to drain iterable to set

swh-public-ci added a comment.May 5 2022, 8:54 PM

Build was aborted

Patch application report for D7751 (id=28028)

Rebasing onto 9562953493...

Current branch diff-target is up to date.
Changes applied before test
commit 1717c3eaa70a5c8e4c73dd6ac59926e8dd9f3f8e
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date:   Thu May 5 13:25:57 2022 -0400

    Add `algos.identifier.identifiers_missing`
    
    Summary:
    This is a small wrapper around the underlying `*_missing` functions in
    order to assist with looking up missing SWHIDs.
    
    This will be a building block to clean up some things in swh-web so that
    https://forge.softwareheritage.org/T4224 doesn't come back.
    
    Reviewers: #reviewers
    
    Differential Revision: https://forge.softwareheritage.org/D7751

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1608/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1608/console

Harbormaster returned this revision to the author for changes because remote builds failed.May 5 2022, 8:54 PM
Harbormaster failed remote builds in B29104: Diff 28028!
Ericson2314 mentioned this in D7749: Cleanup `archive.lookup_missing_hashes` and `api_swhid_known`.May 6 2022, 5:17 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
algos/
44 lines
tests/
algos/
56 lines

Diff 28026

View Options

swh/storage/algos/identifier.py

Loading...
View Options

swh/storage/tests/algos/test_identifer.py

Loading...
About · Developer information · Legal