Page MenuHomeSoftware Heritage

Improve language in add-forge-now help text
ClosedPublic

Authored by jayeshv on Mar 25 2022, 11:45 AM.

Diff Detail

Repository
rDWAPPS Web applications
Branch
language-fix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27811
Build 43536: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 43535: arc lint + arc unit

Event Timeline

Great, a couple of suggestion inline.

swh/web/templates/add_forge_now/create-request.html
212

?

222–223

Remains to technically do it, but i don't whether we want to enter into details here.

228
238
240–245

Build is green

Patch application report for D7430 (id=26891)

Rebasing onto 8d5f258e31...

First, rewinding head to replay your work on top of it...
Applying: Improve language in add-forge-now help text
Changes applied before test
commit d342a78bcb9493febec9c10d85df52b277c4536a
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Mar 25 11:44:08 2022 +0100

    Improve language in add-forge-now help text
    
    Related to T4087

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1578/ for more details.

swh/web/templates/add_forge_now/create-request.html
222–223

i don't know* whether...

Build is green

Patch application report for D7430 (id=26895)

Rebasing onto 1ffff63f70...

First, rewinding head to replay your work on top of it...
Applying: Improve language in add-forge-now help text
Changes applied before test
commit 996adb80c145436c4c00ba8322890734ecb98c37
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Mar 25 12:35:39 2022 +0100

    Improve language in add-forge-now help text
    
    Related to T4087

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1581/ for more details.

This revision is now accepted and ready to land.Mar 25 2022, 2:13 PM
This revision was landed with ongoing or failed builds.Mar 25 2022, 2:17 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7430 (id=26897)

Rebasing onto 1ffff63f70...

Current branch diff-target is up to date.
Changes applied before test
commit cdda03c3aad55d7832a097a476cc3d52551daee9
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Mar 25 12:35:39 2022 +0100

    Improve language in add-forge-now help text
    
    Related to T4087

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1583/ for more details.