Differential D7116

Use the now refactored visit date util from core
ClosedPublic
Actions

Authored by Alphare on Feb 8 2022, 10:16 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDHGa6a4fa0419fa: Use the now refactored visit date util from core

Diff Detail

Repository

rDLDHG Mercurial loader

Branch

refactor

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26651
Build 41678: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 41677: arc lint + arc unit

Event Timeline

Alphare created this revision.Feb 8 2022, 10:16 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 8 2022, 10:16 AM

Alphare added a parent revision: D7114: Move visit date helper from hg loader to core.Feb 8 2022, 10:16 AM

Build has FAILED

Patch application report for D7116 (id=25797)

Rebasing onto 6290d72937...

Current branch diff-target is up to date.

Changes applied before test

commit 5038637b14411458d7425947af8969b6b70ff6a0
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Tue Feb 8 10:15:01 2022 +0100

    Use the now refactored visit date util from core

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/330/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/330/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2022, 10:17 AM

Harbormaster failed remote builds in B26641: Diff 25797!

This needs:

a requirement.txt bump of swh-loader-core
a new release of swh-loader-core once the parent diff lands (for the build to pass).

I'm ok with the change but cannot validate it yet.

@Alphare ^

I've tagged swh.loader.core v2.5 (build ongoing).

Build has FAILED

Patch application report for D7116 (id=25797)

Rebasing onto 6290d72937...

Current branch diff-target is up to date.

Changes applied before test

commit 5038637b14411458d7425947af8969b6b70ff6a0
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Tue Feb 8 10:15:01 2022 +0100

    Use the now refactored visit date util from core

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/332/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/332/console

I've tagged swh.loader.core v2.5 (build ongoing).

swh-loader-core is pypi uploaded.
So I triggered back the build, it should be ok (or red with the right reasons otherwise ;)

Build is green

Patch application report for D7116 (id=25797)

Rebasing onto 6290d72937...

Current branch diff-target is up to date.

Changes applied before test

commit 5038637b14411458d7425947af8969b6b70ff6a0
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Tue Feb 8 10:15:01 2022 +0100

    Use the now refactored visit date util from core

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/333/ for more details.

Harbormaster completed remote builds in B26641: Diff 25797.Feb 8 2022, 11:00 AM

Alphare requested review of this revision.Feb 8 2022, 11:00 AM

Thanks.

This revision is now accepted and ready to land.Feb 8 2022, 11:01 AM

Rebase

This revision was landed with ongoing or failed builds.Feb 8 2022, 11:09 AM

Closed by commit rDLDHGa6a4fa0419fa: Use the now refactored visit date util from core (authored by Alphare). · Explain Why

This revision was automatically updated to reflect the committed changes.

Alphare added a commit: rDLDHGa6a4fa0419fa: Use the now refactored visit date util from core.

Build is green

Patch application report for D7116 (id=25807)

Rebasing onto b080d16a47...

Current branch diff-target is up to date.

Changes applied before test

commit a6a4fa0419fa0d8b4b925dfa5d420970875507c6
Author: Raphaël Gomès <rgomes@octobus.net>
Date:   Tue Feb 8 10:15:01 2022 +0100

    Use the now refactored visit date util from core

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/334/ for more details.

Harbormaster completed remote builds in B26651: Diff 25807.Feb 8 2022, 11:10 AM