T286: Add a calendar-like UI to the origin page
ClosedPublic
Actions

Authored by jbertran on Jul 13 2016, 12:13 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T286: view /browse/origin/ORIGIN_ID/ - calendar-like UI

Commits

R65:5ac52abf1940: Browse: add SWH visit timeline to origin browsing
R65:d901f89434f0: - Change to symlinks in static/lib for flot inclusion - Update calendar from…
R65:e303515d64b2: Backend: get origin visit stats from storage
R65:a1284b387c5c: API: open /api/1/stat/visits/<int:origin>/
R65:f123899b3d80: Service: add origin visit stats from backend
rDWAPPS5ac52abf1940: Browse: add SWH visit timeline to origin browsing
rDWAPPSa1284b387c5c: API: open /api/1/stat/visits/<int:origin>/
rDWAPPSd901f89434f0: - Change to symlinks in static/lib for flot inclusion - Update calendar from…
rDWAPPSf123899b3d80: Service: add origin visit stats from backend
rDWAPPSe303515d64b2: Backend: get origin visit stats from storage

Summary

Backend: get origin visit stats from storage
Service: add origin visit stats from backend
API: open /api/1/stat/visits/<int:origin>/
Browse: add SWH visit timeline to origin browsing

WARNING:

This does not work in its current state, we need to work out how to make the plugin available.

apt-get install libjs-jquery-flot installs everything this needs EXCEPT the tooltip plugin for flot, which is necessary. Do we just accept that symlinks in static/lib works for everything but tooltip, and bundle tooltip in static/lib separately?

Diff Detail

Repository

rDWAPPS Web applications

Branch

T286

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 278
Build 409: Software Heritage Python tests
Build 408: arc lint + arc unit

Event Timeline

jbertran updated this revision to Diff 247.Jul 13 2016, 12:13 PM

jbertran added a task: T286: view /browse/origin/ORIGIN_ID/ - calendar-like UI.

jbertran retitled this revision from to T286: Add a calendar-like UI to the origin page.

jbertran updated this object.

jbertran edited the test plan for this revision. (Show Details)

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 13 2016, 12:13 PM

jbertran updated this object.Jul 13 2016, 12:18 PM

jbertran edited edge metadata.

ardumont added a subscriber: ardumont.Jul 13 2016, 2:35 PM

ardumont added inline comments.

swh/web/ui/static/js/calendar.js
48	Can you please add a comment on this, something like 'circumvent the closure issue on overriden `this` in function...' or something? I'm pretty sure i won't remember this kind of detail later. As this thing is a deal breaker if absent, i think it's worth a comment ^^.
80	Missed 'javascriptdoc'?

ardumont added inline comments.Jul 13 2016, 2:47 PM

swh/web/ui/static/js/calendar.js
69	Excuse me for asking but does this work on say... safari? ^^
88	This looks like the previous function, maybe you could reuse some code?
122	Maybe extract this value in a variable and reuse it.
127	Barf, please, take a look at your formatter. This seems to be messed up again ^^

jbertran marked 5 inline comments as done.Jul 13 2016, 3:02 PM

jbertran added inline comments.

swh/web/ui/static/js/calendar.js
69	Not working on konqueror at any rate ><

ardumont added inline comments.Jul 13 2016, 3:09 PM

swh/web/ui/static/js/calendar.js
174	Some reuse is possible between this and function date_to_tooltip_static below.
swh/web/ui/templates/origin.html
14	If i understood right your first comment, this is the one not packaged, am i right?

Well, looks like to me, something awesome this way comes!

jbertran marked 5 inline comments as done.Jul 13 2016, 3:12 PM

jbertran added inline comments.

swh/web/ui/templates/origin.html
14	Yup.

Temporarily add flot libraries, update calendar

Herald edited edge metadata. · View Herald TranscriptJul 13 2016, 3:15 PM

This does not work in its current state, we need to work out how to make the plugin available.
apt-get install libjs-jquery-flot installs everything this needs EXCEPT the tooltip plugin for flot, which is necessary. Do we just accept that symlinks in static/lib works for everything but tooltip, and bundle tooltip in static/lib separately?

T490 for the flot plugin package issue.