Page MenuHomeSoftware Heritage
Differential D6695

[WIP] Deprecate /origin/directrory and /snapshot/directory routes
AbandonedPublic
Actions

Authored by jayeshv on Nov 26 2021, 3:24 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Maniphest Tasks
T3608: Deprecate most of the /browse/origin/.* URLs
T3698: Deprecate origin directory routes
Summary

WIP
This fix deprecates and redirects /origin/directory?origin_url=<url>,
/origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
to /directory

  • test fixes
  • documentation changes

Related to T3608
Fixes T3698

Diff Detail

Repository
rDWAPPS Web applications
Branch
directory-route
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25308
Build 39560: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 39559: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
42,104 msJenkins > should redirect to browse when archived URL is searched::Tests / Cypress tests / Run cypress tests / Test origin-search should redirect to browse when archived URL is searched
AssertionError: Timed out retrying after 20000ms: expected '/browse/directory/2a9e0d6dee8dc7c87c22fd56731ab5c732282eab/' to equal '/browse/origin/directory/' at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-search.spec.js:165:29)
21,718 msJenkins > should resolve snapshot::Tests / Cypress tests / Run cypress tests / Test origin-search Test valid SWHIDs should resolve snapshot
AssertionError: Timed out retrying after 20000ms: expected '/browse/directory/2a9e0d6dee8dc7c87c22fd56731ab5c732282eab/' to equal '/browse/snapshot/a939fc6ac1a445973cd6eecc04e86afd7b46bbfa/directory/' at searchShouldRedirect (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-search.spec.js:127:27) at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-search.spec.js:406:7)
254 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_available_for_staff_user
266 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_available_for_user_with_permission
275 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_not_available_for_anonymous_user
View Full Test Results (2 Failed · 753 Passed · 5 Skipped)

Event Timeline

jayeshv created this revision.Nov 26 2021, 3:24 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 26 2021, 3:24 PM
swh-public-ci added a comment.Nov 26 2021, 3:46 PM

Build has FAILED

Patch application report for D6695 (id=24319)

Rebasing onto 806623eb53...

Current branch diff-target is up to date.
Changes applied before test
commit 3c5c470e197a498b8a19467e1e8cc2db5c5c0931
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 15:21:38 2021 +0100

    Deprecate /origin/directrory and /snapshot/directory routes
    
    This fix deprecates and redirects /origin/directory?origin_url=<url>,
    /origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
    to /directory
    
    - test fixes
    - documentation changes
    
    Related to T3608
    Fixes T3698

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1247/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1247/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 26 2021, 3:46 PM
Harbormaster failed remote builds in B25193: Diff 24319!
jayeshv updated this revision to Diff 24322.Nov 26 2021, 4:07 PM
  • frontend tests
swh-public-ci added a comment.Nov 26 2021, 4:29 PM

Build was aborted

Patch application report for D6695 (id=24322)

Rebasing onto 806623eb53...

Current branch diff-target is up to date.
Changes applied before test
commit 34a62541e624cd5c1c7c33332c3496559fb720eb
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 16:06:40 2021 +0100

    frontend tests

commit 3c5c470e197a498b8a19467e1e8cc2db5c5c0931
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 15:21:38 2021 +0100

    Deprecate /origin/directrory and /snapshot/directory routes
    
    This fix deprecates and redirects /origin/directory?origin_url=<url>,
    /origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
    to /directory
    
    - test fixes
    - documentation changes
    
    Related to T3608
    Fixes T3698

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1248/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1248/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 26 2021, 4:29 PM
Harbormaster failed remote builds in B25196: Diff 24322!
jayeshv updated this revision to Diff 24345.Nov 29 2021, 11:41 AM
  • failing cypress test
swh-public-ci added a comment.Nov 29 2021, 12:09 PM

Build was aborted

Patch application report for D6695 (id=24345)

Rebasing onto 806623eb53...

Current branch diff-target is up to date.
Changes applied before test
commit 2c651351cc074cf7a218881b08c44e56ad388d1c
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 11:41:14 2021 +0100

    failing cypress test

commit 34a62541e624cd5c1c7c33332c3496559fb720eb
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 16:06:40 2021 +0100

    frontend tests

commit 3c5c470e197a498b8a19467e1e8cc2db5c5c0931
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 15:21:38 2021 +0100

    Deprecate /origin/directrory and /snapshot/directory routes
    
    This fix deprecates and redirects /origin/directory?origin_url=<url>,
    /origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
    to /directory
    
    - test fixes
    - documentation changes
    
    Related to T3608
    Fixes T3698

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1251/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1251/console

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 29 2021, 12:09 PM
Harbormaster failed remote builds in B25219: Diff 24345!
jayeshv updated this revision to Diff 24386.Dec 1 2021, 3:11 PM

tests

swh-public-ci added a comment.Dec 1 2021, 3:33 PM

Build was aborted

Patch application report for D6695 (id=24386)

Rebasing onto 3ff49a05ce...

First, rewinding head to replay your work on top of it...
Applying: Deprecate /origin/directrory and /snapshot/directory routes
Applying: frontend tests
Applying: failing cypress test
Applying: small
Applying: small
Applying: new tests
Changes applied before test
commit a0e17f1acbc74bebe58ab3fd343b20198cfe9b4d
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 15:10:53 2021 +0100

    new tests

commit ef5cbc83599e67a1e3986b770b6834e287ae20cb
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 15:04:56 2021 +0100

    small

commit 4856b4304e13e51e7d7d60294da17136dbb421bd
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 13:55:11 2021 +0100

    small

commit 9024e79bb868b0fcf655cf8b6d821dc06aebd1b2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 11:41:14 2021 +0100

    failing cypress test

commit 6fae93fcef3c96a554d6673b8ebc7bc947832bde
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 16:06:40 2021 +0100

    frontend tests

commit 8471dd9836ce8db76720651d985f5a46d37ac6f8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 15:21:38 2021 +0100

    Deprecate /origin/directrory and /snapshot/directory routes
    
    This fix deprecates and redirects /origin/directory?origin_url=<url>,
    /origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
    to /directory
    
    - test fixes
    - documentation changes
    
    Related to T3608
    Fixes T3698

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1253/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1253/console

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 1 2021, 3:33 PM
Harbormaster failed remote builds in B25263: Diff 24386!
jayeshv updated this revision to Diff 24400.Dec 1 2021, 4:33 PM
  • Missing tests
swh-public-ci added a comment.Dec 1 2021, 4:55 PM

Build has FAILED

Patch application report for D6695 (id=24400)

Rebasing onto 5d35154366...

First, rewinding head to replay your work on top of it...
Applying: Deprecate /origin/directrory and /snapshot/directory routes
Using index info to reconstruct a base tree...
M	swh/web/browse/views/content.py
M	swh/web/browse/views/directory.py
M	swh/web/tests/browse/views/test_content.py
M	swh/web/tests/browse/views/test_directory.py
Falling back to patching base and 3-way merge...
Auto-merging swh/web/tests/browse/views/test_directory.py
CONFLICT (content): Merge conflict in swh/web/tests/browse/views/test_directory.py
Auto-merging swh/web/tests/browse/views/test_content.py
Auto-merging swh/web/browse/views/directory.py
Auto-merging swh/web/browse/views/content.py
Patch failed at 0001 Deprecate /origin/directrory and /snapshot/directory routes

Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".

Rebase failed (ret=1)!




Could not rebase; Attempt merge onto 5d35154366...



Already up to date.





Changes applied before test



commit 0131fa200e074746dc88d5ef024ed6ca9707628c
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 16:32:57 2021 +0100

    Missing tests

commit 8e5aaf4dd4b196280d08eb3e344fbbff3fdb72d5
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 15:10:53 2021 +0100

    new tests

commit 2fe68166fad2dd464f797772b9acd2f7935c05d9
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 15:04:56 2021 +0100

    small

commit 61ce5627b400ca3715aca396554cddbe477e0517
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 13:55:11 2021 +0100

    small

commit 03575f7b9e12bb956edfd7ddbba02647f35b17a4
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 11:41:14 2021 +0100

    failing cypress test

commit dd4e9a447d688073ad06262bae053bff9d5c5cb4
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 16:06:40 2021 +0100

    frontend tests

commit c09322abd6519937f83f7a23c675d4a3d97c7f44
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 15:21:38 2021 +0100

    Deprecate /origin/directrory and /snapshot/directory routes
    
    This fix deprecates and redirects /origin/directory?origin_url=<url>,
    /origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
    to /directory
    
    - test fixes
    - documentation changes
    
    Related to T3608
    Fixes T3698



Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1254/

See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1254/console
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 1 2021, 4:55 PM
Harbormaster failed remote builds in B25277: Diff 24400!
jayeshv updated this revision to Diff 24431.Dec 2 2021, 11:21 AM
    

  • rebase
    • 

  • failing cypress test
    • 

swh-public-ci added a comment.Dec 2 2021, 11:43 AM
Build was aborted



Patch application report for D6695 (id=24431)



Rebasing onto 284eec7e75...



Current branch diff-target is up to date.





Changes applied before test



commit c1008e3edc977f90ddd408a3bbbfa484cf04c058
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:11:41 2021 +0100

    commented failing ui tests

commit bab415352329e13789966d8c7dfc7c7e8e516ee2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 16:32:57 2021 +0100

    Missing tests

commit 5d1219f2d8122ece65efff99eda5ff941713a277
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 15:10:53 2021 +0100

    new tests

commit 1cdc63b8371e3348f87c6070c50e8bf1b85fd6b8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 15:04:56 2021 +0100

    small

commit a8cc226fd89d017b4c2010f1d068358d494ec077
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 13:55:11 2021 +0100

    small

commit eb4d0cda09c8da9f783949433dc11a6211d810f2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 11:41:14 2021 +0100

    failing cypress test

commit 8f0d466eb5c8b54a088dd171b487f90e37a66376
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 16:06:40 2021 +0100

    frontend tests

commit 85f28f24c8d6f85a8d3ccbc9a5defc9107ddfebe
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 15:21:38 2021 +0100

    Deprecate /origin/directrory and /snapshot/directory routes
    
    This fix deprecates and redirects /origin/directory?origin_url=<url>,
    /origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
    to /directory
    
    - test fixes
    - documentation changes
    
    Related to T3608
    Fixes T3698

commit f62bffd9551bb187968aa535c980b25671d265a7
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:17:59 2021 +0100

    rebase



Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1256/

See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1256/console
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 2 2021, 11:43 AM
Harbormaster failed remote builds in B25308: Diff 24431!
jayeshv updated this revision to Diff 24436.Dec 2 2021, 11:52 AM
    

  • more failing tests
    • 

swh-public-ci added a comment.Dec 2 2021, 12:09 PM
Build is green



Patch application report for D6695 (id=24436)



Rebasing onto 284eec7e75...



Current branch diff-target is up to date.





Changes applied before test



commit 5993b0d4c7995a8f2d47cf5993e61bbc895a10d8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:52:26 2021 +0100

    more failing tests

commit c1008e3edc977f90ddd408a3bbbfa484cf04c058
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:11:41 2021 +0100

    commented failing ui tests

commit bab415352329e13789966d8c7dfc7c7e8e516ee2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 16:32:57 2021 +0100

    Missing tests

commit 5d1219f2d8122ece65efff99eda5ff941713a277
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 15:10:53 2021 +0100

    new tests

commit 1cdc63b8371e3348f87c6070c50e8bf1b85fd6b8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 15:04:56 2021 +0100

    small

commit a8cc226fd89d017b4c2010f1d068358d494ec077
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 13:55:11 2021 +0100

    small

commit eb4d0cda09c8da9f783949433dc11a6211d810f2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 11:41:14 2021 +0100

    failing cypress test

commit 8f0d466eb5c8b54a088dd171b487f90e37a66376
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 16:06:40 2021 +0100

    frontend tests

commit 85f28f24c8d6f85a8d3ccbc9a5defc9107ddfebe
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 15:21:38 2021 +0100

    Deprecate /origin/directrory and /snapshot/directory routes
    
    This fix deprecates and redirects /origin/directory?origin_url=<url>,
    /origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
    to /directory
    
    - test fixes
    - documentation changes
    
    Related to T3608
    Fixes T3698

commit f62bffd9551bb187968aa535c980b25671d265a7
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:17:59 2021 +0100

    rebase



See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1257/ for more details.
Harbormaster completed remote builds in B25313: Diff 24436.Dec 2 2021, 12:09 PM
jayeshv requested review of this revision.Dec 2 2021, 12:09 PM
jayeshv updated this revision to Diff 24449.Dec 2 2021, 2:54 PM
    

  • dir swids in frontend tests
    • 

swh-public-ci added a comment.Dec 2 2021, 3:11 PM
Build is green



Patch application report for D6695 (id=24449)



Rebasing onto 284eec7e75...



Current branch diff-target is up to date.





Changes applied before test



commit f3decefcb00b4684de8e4b87669ed3d6d1318208
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 14:54:45 2021 +0100

    dir swids in frontend tests

commit 5993b0d4c7995a8f2d47cf5993e61bbc895a10d8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:52:26 2021 +0100

    more failing tests

commit c1008e3edc977f90ddd408a3bbbfa484cf04c058
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:11:41 2021 +0100

    commented failing ui tests

commit bab415352329e13789966d8c7dfc7c7e8e516ee2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 16:32:57 2021 +0100

    Missing tests

commit 5d1219f2d8122ece65efff99eda5ff941713a277
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 15:10:53 2021 +0100

    new tests

commit 1cdc63b8371e3348f87c6070c50e8bf1b85fd6b8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 15:04:56 2021 +0100

    small

commit a8cc226fd89d017b4c2010f1d068358d494ec077
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 13:55:11 2021 +0100

    small

commit eb4d0cda09c8da9f783949433dc11a6211d810f2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 11:41:14 2021 +0100

    failing cypress test

commit 8f0d466eb5c8b54a088dd171b487f90e37a66376
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 16:06:40 2021 +0100

    frontend tests

commit 85f28f24c8d6f85a8d3ccbc9a5defc9107ddfebe
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 15:21:38 2021 +0100

    Deprecate /origin/directrory and /snapshot/directory routes
    
    This fix deprecates and redirects /origin/directory?origin_url=<url>,
    /origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
    to /directory
    
    - test fixes
    - documentation changes
    
    Related to T3608
    Fixes T3698

commit f62bffd9551bb187968aa535c980b25671d265a7
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:17:59 2021 +0100

    rebase



See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1258/ for more details.
Harbormaster completed remote builds in B25326: Diff 24449.Dec 2 2021, 3:11 PM
jayeshv updated this revision to Diff 24455.Dec 2 2021, 3:55 PM
    

  • More tests
    • 

swh-public-ci added a comment.Dec 2 2021, 4:13 PM
Build is green



Patch application report for D6695 (id=24455)



Rebasing onto 284eec7e75...



Current branch diff-target is up to date.





Changes applied before test



commit da5da1c7d2c7ab111685f69df3399530fffb45d3
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 15:55:08 2021 +0100

    More tests

commit f3decefcb00b4684de8e4b87669ed3d6d1318208
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 14:54:45 2021 +0100

    dir swids in frontend tests

commit 5993b0d4c7995a8f2d47cf5993e61bbc895a10d8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:52:26 2021 +0100

    more failing tests

commit c1008e3edc977f90ddd408a3bbbfa484cf04c058
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:11:41 2021 +0100

    commented failing ui tests

commit bab415352329e13789966d8c7dfc7c7e8e516ee2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 16:32:57 2021 +0100

    Missing tests

commit 5d1219f2d8122ece65efff99eda5ff941713a277
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 15:10:53 2021 +0100

    new tests

commit 1cdc63b8371e3348f87c6070c50e8bf1b85fd6b8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 15:04:56 2021 +0100

    small

commit a8cc226fd89d017b4c2010f1d068358d494ec077
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 13:55:11 2021 +0100

    small

commit eb4d0cda09c8da9f783949433dc11a6211d810f2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 11:41:14 2021 +0100

    failing cypress test

commit 8f0d466eb5c8b54a088dd171b487f90e37a66376
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 16:06:40 2021 +0100

    frontend tests

commit 85f28f24c8d6f85a8d3ccbc9a5defc9107ddfebe
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 15:21:38 2021 +0100

    Deprecate /origin/directrory and /snapshot/directory routes
    
    This fix deprecates and redirects /origin/directory?origin_url=<url>,
    /origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
    to /directory
    
    - test fixes
    - documentation changes
    
    Related to T3608
    Fixes T3698

commit f62bffd9551bb187968aa535c980b25671d265a7
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:17:59 2021 +0100

    rebase



See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1261/ for more details.
Harbormaster completed remote builds in B25331: Diff 24455.Dec 2 2021, 4:13 PM
jayeshv updated this revision to Diff 24478.Dec 3 2021, 12:29 PM
    

  • ui tests
    • 

swh-public-ci added a comment.Dec 3 2021, 12:50 PM
Build has FAILED



Patch application report for D6695 (id=24478)



Rebasing onto 284eec7e75...



Current branch diff-target is up to date.





Changes applied before test



commit 29ff0ed3f187c126a3a0e42715d04142a6d7373d
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 3 12:28:49 2021 +0100

    ui tests

commit da5da1c7d2c7ab111685f69df3399530fffb45d3
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 15:55:08 2021 +0100

    More tests

commit f3decefcb00b4684de8e4b87669ed3d6d1318208
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 14:54:45 2021 +0100

    dir swids in frontend tests

commit 5993b0d4c7995a8f2d47cf5993e61bbc895a10d8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:52:26 2021 +0100

    more failing tests

commit c1008e3edc977f90ddd408a3bbbfa484cf04c058
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:11:41 2021 +0100

    commented failing ui tests

commit bab415352329e13789966d8c7dfc7c7e8e516ee2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 16:32:57 2021 +0100

    Missing tests

commit 5d1219f2d8122ece65efff99eda5ff941713a277
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 15:10:53 2021 +0100

    new tests

commit 1cdc63b8371e3348f87c6070c50e8bf1b85fd6b8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 15:04:56 2021 +0100

    small

commit a8cc226fd89d017b4c2010f1d068358d494ec077
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 13:55:11 2021 +0100

    small

commit eb4d0cda09c8da9f783949433dc11a6211d810f2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 11:41:14 2021 +0100

    failing cypress test

commit 8f0d466eb5c8b54a088dd171b487f90e37a66376
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 16:06:40 2021 +0100

    frontend tests

commit 85f28f24c8d6f85a8d3ccbc9a5defc9107ddfebe
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 15:21:38 2021 +0100

    Deprecate /origin/directrory and /snapshot/directory routes
    
    This fix deprecates and redirects /origin/directory?origin_url=<url>,
    /origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
    to /directory
    
    - test fixes
    - documentation changes
    
    Related to T3608
    Fixes T3698

commit f62bffd9551bb187968aa535c980b25671d265a7
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:17:59 2021 +0100

    rebase



Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1262/

See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1262/console
Harbormaster failed remote builds in B25351: Diff 24478!Dec 3 2021, 12:50 PM
jayeshv updated this revision to Diff 24481.Dec 3 2021, 2:42 PM
    

  • migrated more tests
    • 

swh-public-ci added a comment.Dec 3 2021, 2:58 PM
Build is green



Patch application report for D6695 (id=24481)



Rebasing onto 284eec7e75...



Current branch diff-target is up to date.





Changes applied before test



commit ef821dcac842576947678faa8be902762ab5112f
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 3 14:42:17 2021 +0100

    migrated more tests

commit 29ff0ed3f187c126a3a0e42715d04142a6d7373d
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 3 12:28:49 2021 +0100

    ui tests

commit da5da1c7d2c7ab111685f69df3399530fffb45d3
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 15:55:08 2021 +0100

    More tests

commit f3decefcb00b4684de8e4b87669ed3d6d1318208
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 14:54:45 2021 +0100

    dir swids in frontend tests

commit 5993b0d4c7995a8f2d47cf5993e61bbc895a10d8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:52:26 2021 +0100

    more failing tests

commit c1008e3edc977f90ddd408a3bbbfa484cf04c058
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:11:41 2021 +0100

    commented failing ui tests

commit bab415352329e13789966d8c7dfc7c7e8e516ee2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 16:32:57 2021 +0100

    Missing tests

commit 5d1219f2d8122ece65efff99eda5ff941713a277
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 15:10:53 2021 +0100

    new tests

commit 1cdc63b8371e3348f87c6070c50e8bf1b85fd6b8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 15:04:56 2021 +0100

    small

commit a8cc226fd89d017b4c2010f1d068358d494ec077
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 13:55:11 2021 +0100

    small

commit eb4d0cda09c8da9f783949433dc11a6211d810f2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 11:41:14 2021 +0100

    failing cypress test

commit 8f0d466eb5c8b54a088dd171b487f90e37a66376
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 16:06:40 2021 +0100

    frontend tests

commit 85f28f24c8d6f85a8d3ccbc9a5defc9107ddfebe
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 15:21:38 2021 +0100

    Deprecate /origin/directrory and /snapshot/directory routes
    
    This fix deprecates and redirects /origin/directory?origin_url=<url>,
    /origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
    to /directory
    
    - test fixes
    - documentation changes
    
    Related to T3608
    Fixes T3698

commit f62bffd9551bb187968aa535c980b25671d265a7
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:17:59 2021 +0100

    rebase



See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1263/ for more details.
Harbormaster completed remote builds in B25354: Diff 24481.Dec 3 2021, 2:58 PM
jayeshv updated this revision to Diff 24487.Dec 3 2021, 5:42 PM
    

  • Missing tests
    • 

swh-public-ci added a comment.Dec 3 2021, 5:58 PM
Build has FAILED



Patch application report for D6695 (id=24487)



Rebasing onto 284eec7e75...



Current branch diff-target is up to date.





Changes applied before test



commit 4b01e1baa1b82cbd69e95491e9b1b806674929b0
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 3 17:42:26 2021 +0100

    Missing tests

commit ef821dcac842576947678faa8be902762ab5112f
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 3 14:42:17 2021 +0100

    migrated more tests

commit 29ff0ed3f187c126a3a0e42715d04142a6d7373d
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 3 12:28:49 2021 +0100

    ui tests

commit da5da1c7d2c7ab111685f69df3399530fffb45d3
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 15:55:08 2021 +0100

    More tests

commit f3decefcb00b4684de8e4b87669ed3d6d1318208
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 14:54:45 2021 +0100

    dir swids in frontend tests

commit 5993b0d4c7995a8f2d47cf5993e61bbc895a10d8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:52:26 2021 +0100

    more failing tests

commit c1008e3edc977f90ddd408a3bbbfa484cf04c058
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:11:41 2021 +0100

    commented failing ui tests

commit bab415352329e13789966d8c7dfc7c7e8e516ee2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 16:32:57 2021 +0100

    Missing tests

commit 5d1219f2d8122ece65efff99eda5ff941713a277
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Dec 1 15:10:53 2021 +0100

    new tests

commit 1cdc63b8371e3348f87c6070c50e8bf1b85fd6b8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 15:04:56 2021 +0100

    small

commit a8cc226fd89d017b4c2010f1d068358d494ec077
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 13:55:11 2021 +0100

    small

commit eb4d0cda09c8da9f783949433dc11a6211d810f2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 29 11:41:14 2021 +0100

    failing cypress test

commit 8f0d466eb5c8b54a088dd171b487f90e37a66376
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 16:06:40 2021 +0100

    frontend tests

commit 85f28f24c8d6f85a8d3ccbc9a5defc9107ddfebe
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Nov 26 15:21:38 2021 +0100

    Deprecate /origin/directrory and /snapshot/directory routes
    
    This fix deprecates and redirects /origin/directory?origin_url=<url>,
    /origin/<url>/directory, /snapshot/<id>/directory and /snapshot/<id>/directory/<path>
    to /directory
    
    - test fixes
    - documentation changes
    
    Related to T3608
    Fixes T3698

commit f62bffd9551bb187968aa535c980b25671d265a7
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Dec 2 11:17:59 2021 +0100

    rebase



Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1264/

See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1264/console
Harbormaster failed remote builds in B25360: Diff 24487!Dec 3 2021, 5:58 PM
vlorentz retitled this revision from WIP - Deprecate /origin/directrory and /snapshot/directory routes to [WIP] Deprecate /origin/directrory and /snapshot/directory routes.Aug 10 2022, 11:33 AM
jayeshv abandoned this revision.Aug 22 2022, 4:04 PM
Revision Contents
Changeset List
PathSize
cypress/
integration/
4 lines
62 lines
4 lines
docs/
3 lines
swh/
web/
browse/
428 lines
views/
2 lines
64 lines
49 lines
25 lines
tests/
browse/
views/
2 lines
549 lines
775 lines
46 lines
common/
49 lines
Diff 24431
View Options
cypress/integration/directory.spec.js
Loading...
View Options
cypress/integration/guided-tour.spec.js
Loading...
View Options
cypress/integration/origin-browse.spec.js
Loading...
View Options
docs/uri-scheme-browse-directory.rst
Loading...
View Options
swh/web/browse/snapshot_context.py
Loading...
View Options
swh/web/browse/views/content.py
Loading...
View Options
swh/web/browse/views/directory.py
Loading...
View Options
swh/web/browse/views/origin.py
Loading...
View Options
swh/web/browse/views/snapshot.py
Loading...
View Options
swh/web/tests/browse/views/test_content.py
Loading...
View Options
swh/web/tests/browse/views/test_directory.py
Loading...
View Options
swh/web/tests/browse/views/test_origin.py
Loading...
View Options
swh/web/tests/browse/views/test_snapshot.py
Loading...
View Options
swh/web/tests/common/test_middlewares.py
Loading...
About · Developer information · Legal