Page MenuHomeSoftware Heritage

grammar.js: Segregate sort_by and limit from filters
ClosedPublic

Authored by KShivendu on Jul 26 2021, 8:26 PM.

Details

Summary

The grammar should not allow using sort_by and limit more than once throughout
the query.

Unlike other filters, these two must not be concatenated by 'and' or 'or'

Diff Detail

Repository
rDSEA Archive search
Branch
query-transpiler
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22749
Build 35476: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 35475: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6024 (id=21781)

Rebasing onto 2edbbbe833...

Current branch diff-target is up to date.
Changes applied before test
commit db10813f0cf35c484ad832478d56da9eb004db18
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Tue Jul 13 16:21:51 2021 +0530

    grammar.js: Segregate sort_by and limit from filters
    
    Summary:
    
    The grammar should not allow using sort_by and limit more than once throughout
    the query.
    
    Unlike other filters, these two must not be concatenated by 'and' or 'or'
    
    Test Plan:
    
    Reviewers:
    
    Subscribers:

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/235/ for more details.

Build is green

Patch application report for D6024 (id=21783)

Rebasing onto 2edbbbe833...

Current branch diff-target is up to date.
Changes applied before test
commit 05efa5418c4396fa0094f4b1e6a011af02d037ae
Author: KShivendu <shivendu@iitbhilai.ac.in>
Date:   Tue Jul 13 16:21:51 2021 +0530

    grammar.js: Segregate sort_by and limit from filters
    
    The grammar should not allow using sort_by and limit more than once throughout
    the query.
    
    Unlike other filters, these two must not be concatenated by 'and' or 'or'

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/237/ for more details.

This revision is now accepted and ready to land.Jul 27 2021, 10:02 AM