Page MenuHomeSoftware Heritage
Differential D55

Small outstanding fixes/updates
ClosedPublic
Actions

Authored by jbertran on Jun 21 2016, 12:24 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
R65:2b9a9c68abca: search template: fix indentation
R65:255066fa464a: backend: use the newly opened revision log search route backend tests: update…
rDWAPPS2b9a9c68abca: search template: fix indentation
rDWAPPS255066fa464a: backend: use the newly opened revision log search route backend tests: update…
Summary

fix search template, update backend after storage opened a new route

Diff Detail

Repository
rDWAPPS Web applications
Branch
Fixes
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 221
Build 332: Software Heritage Python tests
Build 331: arc lint + arc unit

Event Timeline

jbertran updated this revision to Diff 186.Jun 21 2016, 12:24 PM
jbertran retitled this revision from to Small outstanding fixes/updates.
jbertran updated this object.
jbertran edited the test plan for this revision. (Show Details)
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 21 2016, 12:24 PM
ardumont added a subscriber: ardumont.Jun 21 2016, 12:31 PM
ardumont added inline comments.
swh/web/ui/templates/upload_and_search.html
51–52

What's this conditional branch for? Do you intend to add some stuff there later?

jbertran updated this revision to Diff 187.Jun 21 2016, 2:09 PM
jbertran edited edge metadata.
  • search template: fix indentation
Herald edited edge metadata. · View Herald TranscriptJun 21 2016, 2:09 PM
ardumont accepted this revision.Jun 21 2016, 2:13 PM
ardumont added a reviewer: ardumont.
ardumont added inline comments.
swh/web/ui/templates/upload_and_search.html
51–52

As per oral conversation, those are nested ifs.

This revision is now accepted and ready to land.Jun 21 2016, 2:13 PM
Closed by commit rDWAPPS255066fa464a: backend: use the newly opened revision log search route backend tests: update… (authored by jbertran). · Explain WhyJun 21 2016, 2:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
web/
ui/
17 lines
templates/
18 lines
tests/
9 lines

Diff 187

View Options

swh/web/ui/backend.py

Loading...
View Options

swh/web/ui/templates/upload_and_search.html

Loading...
View Options

swh/web/ui/tests/test_backend.py

Loading...
About · Developer information · Legal