Differential D5212

mapping: make the regexp check the length of the hash
ClosedPublic
Actions

Authored by TG1999 on Mar 7 2021, 1:45 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDMFCDc299d0db5fd5: mapping: make the regexp check the length of the hash

Summary

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Diff Detail

Repository

rDMFCD ClearlyDefined metadata fetcher

Branch

change_regex

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19765
Build 30686: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 30685: arc lint + arc unit

Event Timeline

TG1999 created this revision.Mar 7 2021, 1:45 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 7 2021, 1:45 PM

Build is green

Patch application report for D5212 (id=18669)

Rebasing onto 0a4906684f...

Current branch diff-target is up to date.

Changes applied before test

commit b60b9c2f33b639f95f54b9b5ab51add0264eb7b7
Author: Tushar Goel <tushar.goel.dav@gmail.com>
Date:   Sun Mar 7 18:14:29 2021 +0530

    mapping: Change regexp
    
    Current regexp doesn't check for length of hash, this update will update regex so it can check length of hash
    
    Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

See https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/126/ for more details.

Harbormaster completed remote builds in B19762: Diff 18669.Mar 7 2021, 1:46 PM

TG1999 requested review of this revision.Mar 7 2021, 1:46 PM

Ping @vlorentz

The first line of a commit message should give a general idea of what the commit does. And you should try to keep the whole commit message concise.

So instead of this:

mapping: Change regexp

Current regexp doesn't check for length of hash, this update will update regex so it can check length of hash

you could write this:

mapping: make the regexp check the length of the hash

which carries exactly the same information, in less than half the words and fits on the first line.

This revision now requires changes to proceed.Mar 8 2021, 9:30 AM

Change commit message

Build is green

Patch application report for D5212 (id=18672)

Rebasing onto 0a4906684f...

Current branch diff-target is up to date.

Changes applied before test

commit c299d0db5fd509f3871cab9d22320cda0d1d7fae
Author: Tushar Goel <tushar.goel.dav@gmail.com>
Date:   Mon Mar 8 14:24:12 2021 +0530

    mapping: make the regexp check the length of the hash
    
    Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

See https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/127/ for more details.

Harbormaster completed remote builds in B19765: Diff 18672.Mar 8 2021, 9:58 AM

vlorentz accepted this revision.Mar 8 2021, 10:05 AM

vlorentz retitled this revision from mapping: Change regexp to mapping: make the regexp check the length of the hash.

vlorentz edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Mar 8 2021, 10:05 AM

Closed by commit rDMFCDc299d0db5fd5: mapping: make the regexp check the length of the hash (authored by TG1999). · Explain WhyMar 8 2021, 11:03 AM

This revision was automatically updated to reflect the committed changes.

TG1999 added a commit: rDMFCDc299d0db5fd5: mapping: make the regexp check the length of the hash.