It's better to use a structured type than 'raw' strings.
Details
Diff Detail
- Repository
- rDMFCD ClearlyDefined metadata fetcher
- Branch
- swhid
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19714 Build 30599: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 30598: arc lint + arc unit
Event Timeline
Build has FAILED
Patch application report for D5200 (id=18619)
Could not rebase; Attempt merge onto b8711b1417...
Updating b8711b1..a122801 Fast-forward requirements-swh.txt | 2 +- swh/clearlydefined/mapping_utils.py | 30 ++++++++++---------------- swh/clearlydefined/tests/test_mapping_utils.py | 30 +++++++++----------------- 3 files changed, 22 insertions(+), 40 deletions(-)
Changes applied before test
commit a122801166a762bc643a1685d451597519875ad6 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Mar 5 09:27:16 2021 +0100 mapping: pass ExtendedSWHID instead of str It's better to use a structured type than 'raw' strings. commit 38adc4748af23fef57aedcb1f05ec15c667f915a Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Mar 5 09:22:49 2021 +0100 mapping: Update swh-model version to 1.0.0 The old SWHID class is deprecated/removed, and RawExtrinsicMetadata no longer takes a 'type' argument.
Link to build: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/122/
See console output for more information: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/122/console
Build has FAILED
Patch application report for D5200 (id=18620)
Could not rebase; Attempt merge onto b8711b1417...
Updating b8711b1..561a622 Fast-forward requirements-swh.txt | 2 +- swh/clearlydefined/mapping_utils.py | 32 +++++++++++--------------- swh/clearlydefined/tests/test_mapping_utils.py | 30 ++++++++---------------- 3 files changed, 24 insertions(+), 40 deletions(-)
Changes applied before test
commit 561a622c9eec93dcaf04586c83d9a6692fda24fe Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Mar 5 09:27:16 2021 +0100 mapping: pass ExtendedSWHID instead of str It's better to use a structured type than 'raw' strings. commit 38adc4748af23fef57aedcb1f05ec15c667f915a Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Mar 5 09:22:49 2021 +0100 mapping: Update swh-model version to 1.0.0 The old SWHID class is deprecated/removed, and RawExtrinsicMetadata no longer takes a 'type' argument.
Link to build: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/123/
See console output for more information: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/123/console
Build has FAILED
Patch application report for D5200 (id=18622)
Could not rebase; Attempt merge onto b8711b1417...
Updating b8711b1..eeb111b Fast-forward requirements-swh.txt | 2 +- swh/clearlydefined/mapping_utils.py | 32 ++++++++++-------------- swh/clearlydefined/tests/test_mapping_utils.py | 34 +++++++++----------------- 3 files changed, 26 insertions(+), 42 deletions(-)
Changes applied before test
commit eeb111b2cf23cefd85533195035b86f739f022c3 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Mar 5 09:27:16 2021 +0100 mapping: pass ExtendedSWHID instead of str It's better to use a structured type than 'raw' strings. commit 38adc4748af23fef57aedcb1f05ec15c667f915a Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Mar 5 09:22:49 2021 +0100 mapping: Update swh-model version to 1.0.0 The old SWHID class is deprecated/removed, and RawExtrinsicMetadata no longer takes a 'type' argument.
Link to build: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/124/
See console output for more information: https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/124/console
Build is green
Patch application report for D5200 (id=18623)
Could not rebase; Attempt merge onto b8711b1417...
Updating b8711b1..0a49066 Fast-forward requirements-swh.txt | 2 +- swh/clearlydefined/mapping_utils.py | 34 ++++++++++++-------------- swh/clearlydefined/tests/test_mapping_utils.py | 34 +++++++++----------------- 3 files changed, 28 insertions(+), 42 deletions(-)
Changes applied before test
commit 0a4906684f9710b7761c8d008742afc02a258206 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Mar 5 09:27:16 2021 +0100 mapping: pass ExtendedSWHID instead of str It's better to use a structured type than 'raw' strings. commit 38adc4748af23fef57aedcb1f05ec15c667f915a Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Mar 5 09:22:49 2021 +0100 mapping: Update swh-model version to 1.0.0 The old SWHID class is deprecated/removed, and RawExtrinsicMetadata no longer takes a 'type' argument.
See https://jenkins.softwareheritage.org/job/DMFCD/job/tests-on-diff/125/ for more details.