Differential D5184

Add missing server tests
ClosedPublic
Actions

Authored by vsellier on Mar 2 2021, 5:51 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3076: [swh-search] Improve the index/mapping migration process

Commits

rDSEA4ddd6949aa83: Add missing server tests

Summary

Related to T3076

Diff Detail

Repository

rDSEA Archive search

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19617
Build 30441: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 30440: arc lint + arc unit

Event Timeline

vsellier created this revision.Mar 2 2021, 5:51 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 2 2021, 5:51 PM

Build is green

Patch application report for D5184 (id=18536)

Rebasing onto 04dadef938...

Current branch diff-target is up to date.

Changes applied before test

commit e68ec97f9e7cd5de2af880134704240045a6414e
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Mar 2 17:49:14 2021 +0100

    Add server tests
    
    Related to T3076

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/94/ for more details.

Harbormaster completed remote builds in B19615: Diff 18536.Mar 2 2021, 5:54 PM

vsellier requested review of this revision.Mar 2 2021, 5:54 PM

ardumont added a subscriber: ardumont.Mar 2 2021, 5:59 PM

ardumont added inline comments.

swh/search/tests/test_server.py
1	copyright headers ;)
31	make those type appear directly in the signature and drop them from the docstring.
45–47	so you can drop the "str/dict" type (Union[str, Dict]) in the signature.
54	config_path
69

Update according review's feedbacks

Build is green

Patch application report for D5184 (id=18537)

Rebasing onto 04dadef938...

Current branch diff-target is up to date.

Changes applied before test

commit 1b2c19a4768ad43f3c30c0cb04c6e45fce3f2533
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Mar 2 17:49:14 2021 +0100

    Add missing server tests
    
    Related to T3076

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/95/ for more details.

Harbormaster completed remote builds in B19616: Diff 18537.Mar 2 2021, 6:15 PM

vsellier retitled this revision from Add server tests to Add missing server tests.Mar 2 2021, 6:19 PM

Remove a useless parameter of the load_and_check_config function

Build is green

Patch application report for D5184 (id=18538)

Rebasing onto 04dadef938...

Current branch diff-target is up to date.

Changes applied before test

commit 4ddd6949aa8324ece42dac232566e2b417e8de03
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Tue Mar 2 17:49:14 2021 +0100

    Add missing server tests
    
    Related to T3076

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/96/ for more details.

Harbormaster completed remote builds in B19617: Diff 18538.Mar 2 2021, 6:22 PM

ardumont accepted this revision.Mar 2 2021, 6:24 PM

This revision is now accepted and ready to land.Mar 2 2021, 6:24 PM

Closed by commit rDSEA4ddd6949aa83: Add missing server tests (authored by vsellier). · Explain WhyMar 2 2021, 6:31 PM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rDSEA4ddd6949aa83: Add missing server tests.