Differential D4978

Adapt origin_get_latest_visit_status according to latest api change
ClosedPublic
Actions

Authored by ardumont on Feb 1 2021, 10:06 AM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDCIDX2be2c8226782: Adapt origin_get_latest_visit_status according to latest api change

Summary

Related to D4976

Test Plan

tox
(failing until swh.storage > 0.21 is released)

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18977
Build 29404: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 29403: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 1 2021, 10:06 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 1 2021, 10:06 AM

ardumont mentioned this in D4976: storage: Make origin_get_latest_visit_status return OriginVisitStatus.Feb 1 2021, 10:06 AM

Build has FAILED

Patch application report for D4978 (id=17765)

Rebasing onto 3baf8bb919...

Current branch diff-target is up to date.

Changes applied before test

commit 990a554eb5c3687ea27f6a3347853ac1cbe0ca3a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 1 09:51:58 2021 +0100

    Adapt origin_get_latest_visit_status according to latest api change

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/142/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/142/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 1 2021, 10:07 AM

Harbormaster failed remote builds in B18906: Diff 17765!

ardumont edited the test plan for this revision. (Show Details)Feb 1 2021, 12:26 PM

Build is green

Patch application report for D4978 (id=17765)

Rebasing onto cd42c66721...

First, rewinding head to replay your work on top of it...
Applying: Adapt origin_get_latest_visit_status according to latest api change

Changes applied before test

commit 7e66994811af7ccdd0955a87764b35a988312505
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 1 09:51:58 2021 +0100

    Adapt origin_get_latest_visit_status according to latest api change

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/145/ for more details.

Harbormaster completed remote builds in B18906: Diff 17765.Feb 3 2021, 12:31 PM

ardumont requested review of this revision.Feb 3 2021, 12:31 PM

Rebase

Build is green

Patch application report for D4978 (id=17855)

Rebasing onto cd42c66721...

Current branch diff-target is up to date.

Changes applied before test

commit 2be2c8226782a15842a68e71c51fc9cd4229c55a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Feb 1 09:51:58 2021 +0100

    Adapt origin_get_latest_visit_status according to latest api change

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/146/ for more details.

Harbormaster completed remote builds in B18977: Diff 17855.Feb 3 2021, 2:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2021, 2:09 PM

Closed by commit rDCIDX2be2c8226782: Adapt origin_get_latest_visit_status according to latest api change (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCIDX2be2c8226782: Adapt origin_get_latest_visit_status according to latest api change.