Page MenuHomeSoftware Heritage
Differential D4939

gitlab: Adapt celery task implementations to the new lister api
ClosedPublic
Actions

Authored by ardumont on Jan 25 2021, 2:11 PM.

Details

Reviewers
vsellier
Group Reviewers
Reviewers
Maniphest Tasks
T2987: Port gitlab lister to the new `swh.lister.pattern.Lister` API
Commits
rDLS02871f16c9f8: gitlab: Adapt celery task implementations to the new lister api
Summary

Related to T2987

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18715
Build 28968: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 28967: arc lint + arc unit

Event Timeline

ardumont created this revision.Jan 25 2021, 2:11 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 25 2021, 2:11 PM
swh-public-ci added a comment.Jan 25 2021, 2:14 PM

Build has FAILED

Patch application report for D4939 (id=17561)

Could not rebase; Attempt merge onto 7f1609265f...

Updating 7f16092..3f7d325
Fast-forward
 swh/lister/gitlab/lister.py            |   5 +-
 swh/lister/gitlab/tasks.py             |  44 +++-------
 swh/lister/gitlab/tests/test_lister.py |  41 ++++------
 swh/lister/gitlab/tests/test_tasks.py  | 143 ++++++---------------------------
 4 files changed, 52 insertions(+), 181 deletions(-)
Changes applied before test
commit 3f7d325d064dee1c1861434a6d5243ae37be7b4b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 14:09:43 2021 +0100

    gitlab: Adapt celery task implementations to the new lister api
    
    Related to T2987

commit ce87a8f7b254892f63b204e8178c56b3201585ea
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 13:46:05 2021 +0100

    gitlab: Let the lister compute the internal project listing page
    
    Related to T2987

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/149/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/149/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 25 2021, 2:14 PM
Harbormaster failed remote builds in B18696: Diff 17561!
ardumont updated this revision to Diff 17564.Jan 25 2021, 2:20 PM

Fix unused imports removal

swh-public-ci added a comment.Jan 25 2021, 2:23 PM

Build has FAILED

Patch application report for D4939 (id=17564)

Could not rebase; Attempt merge onto 7f1609265f...

Updating 7f16092..76e9978
Fast-forward
 swh/lister/gitlab/lister.py            |   5 +-
 swh/lister/gitlab/tasks.py             |  44 ++--------
 swh/lister/gitlab/tests/test_lister.py |  41 ++++-----
 swh/lister/gitlab/tests/test_tasks.py  | 146 ++++++---------------------------
 4 files changed, 52 insertions(+), 184 deletions(-)
Changes applied before test
commit 76e9978c4f8c51ed9f430e80efd6022f25a68f76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 14:09:43 2021 +0100

    gitlab: Adapt celery task implementations to the new lister api
    
    Related to T2987

commit ce87a8f7b254892f63b204e8178c56b3201585ea
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 13:46:05 2021 +0100

    gitlab: Let the lister compute the internal project listing page
    
    Related to T2987

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/150/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/150/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 25 2021, 2:23 PM
Harbormaster failed remote builds in B18699: Diff 17564!
swh-public-ci added a comment.Jan 25 2021, 2:26 PM

Build has FAILED

Patch application report for D4939 (id=17564)

Could not rebase; Attempt merge onto 7f1609265f...

Updating 7f16092..76e9978
Fast-forward
 swh/lister/gitlab/lister.py            |   5 +-
 swh/lister/gitlab/tasks.py             |  44 ++--------
 swh/lister/gitlab/tests/test_lister.py |  41 ++++-----
 swh/lister/gitlab/tests/test_tasks.py  | 146 ++++++---------------------------
 4 files changed, 52 insertions(+), 184 deletions(-)
Changes applied before test
commit 76e9978c4f8c51ed9f430e80efd6022f25a68f76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 14:09:43 2021 +0100

    gitlab: Adapt celery task implementations to the new lister api
    
    Related to T2987

commit ce87a8f7b254892f63b204e8178c56b3201585ea
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 13:46:05 2021 +0100

    gitlab: Let the lister compute the internal project listing page
    
    Related to T2987

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/151/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/151/console

swh-public-ci added a comment.Jan 25 2021, 2:32 PM

Build has FAILED

Patch application report for D4939 (id=17564)

Could not rebase; Attempt merge onto 7f1609265f...

Updating 7f16092..76e9978
Fast-forward
 swh/lister/gitlab/lister.py            |   5 +-
 swh/lister/gitlab/tasks.py             |  44 ++--------
 swh/lister/gitlab/tests/test_lister.py |  41 ++++-----
 swh/lister/gitlab/tests/test_tasks.py  | 146 ++++++---------------------------
 4 files changed, 52 insertions(+), 184 deletions(-)
Changes applied before test
commit 76e9978c4f8c51ed9f430e80efd6022f25a68f76
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 14:09:43 2021 +0100

    gitlab: Adapt celery task implementations to the new lister api
    
    Related to T2987

commit ce87a8f7b254892f63b204e8178c56b3201585ea
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 13:46:05 2021 +0100

    gitlab: Let the lister compute the internal project listing page
    
    Related to T2987

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/152/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/152/console

ardumont updated this revision to Diff 17577.Jan 25 2021, 2:48 PM

Rebase

swh-public-ci added a comment.Jan 25 2021, 2:51 PM

Build is green

Patch application report for D4939 (id=17577)

Rebasing onto 59c9abb916...

Current branch diff-target is up to date.
Changes applied before test
commit 9e518c521a3c2cf52287077209837b37f06d65da
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 14:09:43 2021 +0100

    gitlab: Adapt celery task implementations to the new lister api
    
    Related to T2987

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/154/ for more details.

Harbormaster completed remote builds in B18712: Diff 17577.Jan 25 2021, 2:51 PM
ardumont requested review of this revision.Jan 25 2021, 2:51 PM
vsellier accepted this revision.Jan 25 2021, 3:13 PM
vsellier added a subscriber: vsellier.

LGTM

This revision is now accepted and ready to land.Jan 25 2021, 3:13 PM
ardumont updated this revision to Diff 17580.Jan 25 2021, 3:14 PM

Rebase

swh-public-ci added a comment.Jan 25 2021, 3:17 PM

Build is green

Patch application report for D4939 (id=17580)

Rebasing onto e4a590fc7f...

Current branch diff-target is up to date.
Changes applied before test
commit 02871f16c9f833a716a0bd4dc1505d487864ee10
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Jan 25 14:09:43 2021 +0100

    gitlab: Adapt celery task implementations to the new lister api
    
    Related to T2987

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/156/ for more details.

Harbormaster completed remote builds in B18715: Diff 17580.Jan 25 2021, 3:17 PM
Closed by commit rDLS02871f16c9f8: gitlab: Adapt celery task implementations to the new lister api (authored by ardumont). · Explain WhyJan 25 2021, 3:24 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLS02871f16c9f8: gitlab: Adapt celery task implementations to the new lister api.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
lister/
gitlab/
44 lines100%
Loading...
tests/
146 lines100%
Loading...

Diff 17580

View Options

swh/lister/gitlab/tasks.py

Loading...
View Options

swh/lister/gitlab/tests/test_tasks.py

Loading...
About · Developer information · Legal