Differential D4908

Do not consider duplicated messages as uneventful event
ClosedPublic
Actions

Authored by vsellier on Jan 21 2021, 5:17 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2978: Deploy visit-stats journal client on staging

Commits

rDSCH25d036ef4503: Do not consider duplicated messages as uneventful event

Summary

Avoid to copy the eventful date to the uneventful date when a
duplicated message (same date/same snapshot) is received,

related to T2978

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 18633
Build 28825: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 28824: arc lint + arc unit

Event Timeline

vsellier created this revision.Jan 21 2021, 5:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 21 2021, 5:17 PM

Build is green

Patch application report for D4908 (id=17486)

Rebasing onto af3789891f...

Current branch diff-target is up to date.

Changes applied before test

commit eaa4f2598592e409222d6c882b41817ab8bbf2fc
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Thu Jan 21 16:15:26 2021 +0100

    Do not consider duplicated messages as uneventful event
    
    Avoid to copy the eventful date to the uneventful date when a
    duplicated message (same date/same snapshot) is received,
    
    related to T2978

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/230/ for more details.

Harbormaster completed remote builds in B18620: Diff 17486.Jan 21 2021, 5:19 PM

vsellier requested review of this revision.Jan 21 2021, 5:19 PM

Test with "several" database upserts as it's more realistic

ardumont accepted this revision.Jan 21 2021, 7:06 PM

This revision is now accepted and ready to land.Jan 21 2021, 7:06 PM

Build is green

Patch application report for D4908 (id=17497)

Rebasing onto 03460207a1...

First, rewinding head to replay your work on top of it...
Applying: Do not consider duplicated messages as uneventful event

Changes applied before test

commit e315dea0e6a8d01e34283b4445401b8a6395d15b
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Thu Jan 21 16:15:26 2021 +0100

    Do not consider duplicated messages as uneventful event
    
    Avoid to copy the eventful date to the uneventful date when a
    duplicated message (same date/same snapshot) is received,
    
    related to T2978

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/240/ for more details.

Harbormaster completed remote builds in B18631: Diff 17497.Jan 21 2021, 7:08 PM

rebase

Build is green

Patch application report for D4908 (id=17499)

Rebasing onto 03460207a1...

Current branch diff-target is up to date.

Changes applied before test

commit 25d036ef45033108389d516226c2bf580714dff0
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Thu Jan 21 16:15:26 2021 +0100

    Do not consider duplicated messages as uneventful event
    
    Avoid to copy the eventful date to the uneventful date when a
    duplicated message (same date/same snapshot) is received,
    
    related to T2978

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/242/ for more details.

Harbormaster completed remote builds in B18633: Diff 17499.Jan 21 2021, 7:18 PM

Closed by commit rDSCH25d036ef4503: Do not consider duplicated messages as uneventful event (authored by vsellier). · Explain WhyJan 21 2021, 7:28 PM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rDSCH25d036ef4503: Do not consider duplicated messages as uneventful event.