Page MenuHomeSoftware Heritage

fs: add cache/ directory under mount point
ClosedPublic

Authored by haltode on Dec 14 2020, 3:42 PM.

Diff Detail

Repository
rDFUSE FUSE virtual file system
Branch
feature/cache-rootdir
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17936
Build 27711: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 27710: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D4734 (id=16769)

Rebasing onto 6e413667a2...

Current branch diff-target is up to date.
Changes applied before test
commit 335845bb23c43b0ea63718237a37237b9f26c717
Author: Thibault Allançon <haltode@gmail.com>
Date:   Mon Dec 14 15:40:24 2020 +0100

    fs: add cache/ directory under mounting point
    
    Related to T2771.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/235/ for more details.

zack retitled this revision from fs: add cache/ directory under mounting point to fs: add cache/ directory under mount point.Dec 14 2020, 3:46 PM

Add more context to commit message

Build is green

Patch application report for D4734 (id=16770)

Rebasing onto 6e413667a2...

Current branch diff-target is up to date.
Changes applied before test
commit 642c015f911caa78689f15559b5c389fb459d3bd
Author: Thibault Allançon <haltode@gmail.com>
Date:   Mon Dec 14 15:40:24 2020 +0100

    fs: add cache/ directory under mount point
    
    Related to T2771.
    
    Add a new 'cache/' directory along 'archive/' and 'origins/' in order to
    navigate previously cached artifacts and for a future use-case about
    cache invalidation on specific objects.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/236/ for more details.

zack requested changes to this revision.Dec 14 2020, 5:05 PM
zack added a subscriber: zack.
zack added inline comments.
docs/design.md
63

better/simpler: "on-disk representation of locally cached objects and metadata"
(bonus point: "metadata" explains both origins and .json files)

64–65

better/simpler and also more correct: "Via this directory you can browse cached data and selectively remove them from the cache, freeing disk space. (See swh fs clean in the CLI to completely empty the cache.)" (with a link to the CLI doc)

all is good starting with the second sentence "The directory is populated [etc.]"

swh/fuse/fs/mountpoint.py
140

write this :)

This revision now requires changes to proceed.Dec 14 2020, 5:05 PM

Build is green

Patch application report for D4734 (id=16776)

Rebasing onto 6e413667a2...

Current branch diff-target is up to date.
Changes applied before test
commit 7154e451ffd589fa36d62fd3a4f03f974d697983
Author: Thibault Allançon <haltode@gmail.com>
Date:   Mon Dec 14 15:40:24 2020 +0100

    fs: add cache/ directory under mount point
    
    Related to T2771.
    
    Add a new 'cache/' directory along 'archive/' and 'origins/' in order to
    navigate previously cached artifacts and for a future use-case about
    cache invalidation on specific objects.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/237/ for more details.

This revision is now accepted and ready to land.Dec 14 2020, 6:01 PM