Differential D4711

test_journal_client: Migrate to pytest
ClosedPublic
Actions

Authored by ardumont on Dec 9 2020, 10:33 PM.

Details

Reviewers

vsellier

Group Reviewers

Reviewers

Commits

rDSEAc7cd34179636: test_journal_client: Migrate to pytest

Test Plan

tox

Diff Detail

Repository

rDSEA Archive search

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17856
Build 27591: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 27590: arc lint + arc unit

Event Timeline

ardumont created this revision.Dec 9 2020, 10:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 9 2020, 10:33 PM

Build is green

Patch application report for D4711 (id=16683)

Could not rebase; Attempt merge onto e72a785757...

Updating e72a785..c7cd341
Fast-forward
 swh/search/journal_client.py            |  2 +-
 swh/search/tests/test_cli.py            |  1 -
 swh/search/tests/test_journal_client.py | 88 ++++++++++++++++-----------------
 3 files changed, 44 insertions(+), 47 deletions(-)

Changes applied before test

commit c7cd341796369521381ebcfba7dba0695bfadf6a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Dec 9 22:32:29 2020 +0100

    test_journal_client: Migrate to pytest

commit ab27eae1356a3a36475c65421abe0f9dcc2a6192
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Dec 9 22:16:23 2020 +0100

    search.journal_client: Fix key error
    
    Prior to this commit the key used was origin_url. After running the following
    through docker, the actual key used is `id`.
    
    Related to T2817

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/55/ for more details.

Harbormaster completed remote builds in B17856: Diff 16683.Dec 9 2020, 10:35 PM

vsellier accepted this revision.Dec 10 2020, 9:48 AM

This revision is now accepted and ready to land.Dec 10 2020, 9:48 AM

Closed by commit rDSEAc7cd34179636: test_journal_client: Migrate to pytest (authored by ardumont). · Explain WhyDec 10 2020, 9:49 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSEAc7cd34179636: test_journal_client: Migrate to pytest.