Differential D4701

Allow configuration through cli or config file
ClosedPublic
Actions

Authored by vsellier on Dec 9 2020, 5:56 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2817: Enable the swh-search environment in staging

Commits

rDSEAe72a785757fb: Allow configuration through cli or config file

Summary

The default values got removed because they were always overriding
the configuration file values.
They are now mandatory to be specified either through cli parameters
or configuration file.
If both are specified, the cli parameters have the highest priority.

Related to T2817
Related to D4699

Test Plan

tox

Diff Detail

Repository

rDSEA Archive search

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17840
Build 27570: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 27569: arc lint + arc unit

Event Timeline

vsellier created this revision.Dec 9 2020, 5:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 9 2020, 5:56 PM

Build is green

Patch application report for D4701 (id=16666)

Rebasing onto 27f82bafea...

Current branch diff-target is up to date.

Changes applied before test

commit e72a785757fb40e6f33f2a268bc4fcab3a9ab1c7
Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
Date:   Wed Dec 9 17:48:02 2020 +0100

    Allow configuration through cli or config file
    
    The default values got removed because they were always overriding
    the configuration file values.
    They are now mandatory to be specified either through cli parameters
    or configuration file.
    If both are specified, the cli parameters have the highest priority.
    
    Related to T2817

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/53/ for more details.

Harbormaster completed remote builds in B17840: Diff 16666.Dec 9 2020, 5:59 PM