Differential D4657

fuse: origin: properly handle invalid origin URL
ClosedPublic
Actions

Authored by haltode on Dec 3 2020, 4:05 PM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Maniphest Tasks

T2839: ls "<mountpoint>/origins/<invalidurl>" creates two empty directory entries with the same name

Commits

rDFUSEfbfed4d9a4fc: fuse: origin: properly handle invalid origin URL

Summary

Fix T2839.

Diff Detail

Repository

rDFUSE FUSE virtual file system

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Dec 3 2020, 4:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 3 2020, 4:05 PM

Build is green

Patch application report for D4657 (id=16520)

Rebasing onto 4a2f73c9ba...

Current branch diff-target is up to date.

Changes applied before test

commit 9e1d48462572c83b43b1911d6c46d81ce3d8d1b7
Author: Thibault Allançon <haltode@gmail.com>
Date:   Thu Dec 3 15:58:45 2020 +0100

    fuse: origin: properly handle invalid origin URL
    
    Fix T2839.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/220/ for more details.

Harbormaster completed remote builds in B17706: Diff 16520.Dec 3 2020, 4:08 PM

Use ValueError instead of HTTPError
Add requests in requirements.txt

Build is green

Patch application report for D4657 (id=16521)

Rebasing onto 4a2f73c9ba...

Current branch diff-target is up to date.

Changes applied before test

commit fbfed4d9a4fc78306f1b85f8f75238630d719c73
Author: Thibault Allançon <haltode@gmail.com>
Date:   Thu Dec 3 15:58:45 2020 +0100

    fuse: origin: properly handle invalid origin URL
    
    Fix T2839.

See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/221/ for more details.

Harbormaster completed remote builds in B17707: Diff 16521.Dec 3 2020, 4:25 PM

zack accepted this revision.Dec 3 2020, 4:27 PM

This revision is now accepted and ready to land.Dec 3 2020, 4:27 PM

Closed by commit rDFUSEfbfed4d9a4fc: fuse: origin: properly handle invalid origin URL (authored by haltode). · Explain WhyDec 3 2020, 4:28 PM

This revision was automatically updated to reflect the committed changes.

haltode added a commit: rDFUSEfbfed4d9a4fc: fuse: origin: properly handle invalid origin URL.