Differential D4445

Override host ips in vagrant environment
ClosedPublic
Actions

Authored by vsellier on Nov 9 2020, 9:51 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

System administrators

Commits

rSPSITE47d0ec201bc8: Override host ips in vagrant environment

Summary

Allow to plug the services locally and avoir to interact with the real hosts.
There are no changes on the real configuration (production/staging) as the hostname are only defined on the vagrant subnet

Test Plan

➜  puppet-environment git:(master) ✗ bin/octocatalog-diff worker01
Found host worker01.softwareheritage.org
Cloning into '/tmp/swh-ocd.zeR3aWd8/environments/production/data/private'...
done.
Cloning into '/tmp/swh-ocd.zeR3aWd8/environments/staging/data/private'...
done.
*** Running octocatalog-diff on host worker01.softwareheritage.org
I, [2020-11-09T09:50:25.756098 #19268]  INFO -- : Catalogs compiled for worker01.softwareheritage.org
I, [2020-11-09T09:50:26.737459 #19268]  INFO -- : Diffs computed for worker01.softwareheritage.org
I, [2020-11-09T09:50:26.737494 #19268]  INFO -- : No differences
*** End octocatalog-diff on worker01.softwareheritage.org

Diff Detail

Repository

rSPSITE puppet-swh-site

Branch

staging

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16948
Build 26147: arc lint + arc unit

Event Timeline

vsellier created this revision.Nov 9 2020, 9:51 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 9 2020, 9:51 AM

Harbormaster completed remote builds in B16944: Diff 15729.Nov 9 2020, 9:51 AM

vsellier edited reviewers, added: System administrators; removed: Reviewers.Nov 9 2020, 9:56 AM

ardumont added a subscriber: ardumont.Nov 9 2020, 9:57 AM

ardumont added inline comments.

data/subnets/vagrant.yaml
43	one s too many ;)

nice touch!

And that won't touch production/staging as nothing is defined for it (list is empty ;)

great, i did not check the ips yet though.

remove wrong plural

Harbormaster completed remote builds in B16946: Diff 15731.Nov 9 2020, 10:19 AM

Use an alias for sentry entry to clarify the internal ip usage

Harbormaster completed remote builds in B16947: Diff 15732.Nov 9 2020, 10:23 AM

Fix previous too enthusiastic commit

Harbormaster completed remote builds in B16948: Diff 15733.Nov 9 2020, 10:26 AM

lgtm, thanks.

This revision is now accepted and ready to land.Nov 9 2020, 10:27 AM

Closed by commit rSPSITE47d0ec201bc8: Override host ips in vagrant environment (authored by vsellier). · Explain WhyNov 9 2020, 10:28 AM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rSPSITE47d0ec201bc8: Override host ips in vagrant environment.

Revision Contents
Changeset List

Path

Size

data/

subnets/

66 lines

site-modules/

profile/

manifests/

static_hostnames.pp

13 lines

role/

manifests/

2 lines

Diff 15733

data/subnets/vagrant.yaml

Loading...

site-modules/profile/manifests/static_hostnames.pp

Loading...

site-modules/role/manifests/swh_base.pp

Loading...