Differential D4328

pytest_plugin declaration to top-level conftest
ClosedPublic
Actions

Authored by ardumont on Oct 22 2020, 1:45 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDCOREdb31d8a0a665: Move pytest_plugin declaration to top-level conftest

Summary

Defining 'pytest_plugins' in a non-top-level conftest is no longer supported
because it affects the entire directory tree in a non-explicit way.

(not really for review, just ensuring it's working ok in ci)

unstuck build [1]

[1] https://jenkins.softwareheritage.org/view/Debian%20packages/job/debian/job/packages/job/DCORE/job/gbp-buildpackage/138/console

Test Plan

tox

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 22 2020, 1:45 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 22 2020, 1:45 PM

Rework commit message

Build is green

Patch application report for D4328 (id=15317)

Rebasing onto 97c091e04d...

Current branch diff-target is up to date.

Changes applied before test

commit 2c8971f16d802a85728af055ae360bea90dd77a5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 22 13:44:12 2020 +0200

    pytest_plugin declaration to top-level conftest
    
    Defining 'pytest_plugins' in a non-top-level conftest is no longer supported
    because it affects the entire directory tree in a non-explicit way.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/109/ for more details.

Harbormaster completed remote builds in B16545: Diff 15317.Oct 22 2020, 1:46 PM

Build is green

Patch application report for D4328 (id=15318)

Rebasing onto 97c091e04d...

Current branch diff-target is up to date.

Changes applied before test

commit db31d8a0a665e039e9474ba0bec7a73c5fe3a4cd
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Oct 22 13:44:12 2020 +0200

    Move pytest_plugin declaration to top-level conftest
    
    Defining 'pytest_plugins' in a non-top-level conftest is no longer supported
    because it affects the entire directory tree in a non-explicit way.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/110/ for more details.

Harbormaster completed remote builds in B16546: Diff 15318.Oct 22 2020, 1:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 22 2020, 1:51 PM

Closed by commit rDCOREdb31d8a0a665: Move pytest_plugin declaration to top-level conftest (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCOREdb31d8a0a665: Move pytest_plugin declaration to top-level conftest.