Closes T2709.
Details
Details
- Reviewers
zack - Group Reviewers
Reviewers - Maniphest Tasks
- T2709: hangs with: ERROR:root:Unknown SWHID: 'swh:1:dir:be2222d58268b1ba08e612ed57c21c703653e653'
- Commits
- rDFUSEe178e7c4e234: fuse: add error handling around HTTP errors (web API)
Diff Detail
Diff Detail
- Repository
- rDFUSE FUSE virtual file system
- Branch
- feature/web-api-error-handling
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 16428 Build 25302: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 25301: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D4301 (id=15189)
Rebasing onto 5c11efe3ae...
Current branch diff-target is up to date.
Changes applied before test
commit e7521a6eb4f8e541276120b262f6387b682c2875
Author: Thibault Allançon <haltode@gmail.com>
Date: Mon Oct 19 10:55:23 2020 +0200
fuse: add error handling around HTTP errors (web API)
Closes T2709.See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/98/ for more details.
Comment Actions
just a style matter: instead of "error during BLA: {err}", please use something like "cannot BLA: {err}", which is more relevant for the user
(I still haven't tried this, but I will before accepting)
Edit: I've now tested this, and it works fine !
Comment Actions
Build is green
Patch application report for D4301 (id=15190)
Rebasing onto 5c11efe3ae...
Current branch diff-target is up to date.
Changes applied before test
commit a2f4be3df7801afae3cde5e11cf2107e92bb39dc
Author: Thibault Allançon <haltode@gmail.com>
Date: Mon Oct 19 10:55:23 2020 +0200
fuse: add error handling around HTTP errors (web API)
Closes T2709.See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/99/ for more details.
| swh/fuse/fuse.py | ||
|---|---|---|
| 88 | better: "Cannot fetch metadata for object {swhid}: {err}" | |
| 112 | better: "Cannot fetch blob for object {swhid}: {err}" | |
| 233 | This should be moved inside the for loop, this way one failure won't stop others. | |
Comment Actions
Build is green
Patch application report for D4301 (id=15192)
Rebasing onto 5c11efe3ae...
Current branch diff-target is up to date.
Changes applied before test
commit e178e7c4e2344ad7ef26f5d5359cb0c1d0a68db2
Author: Thibault Allançon <haltode@gmail.com>
Date: Mon Oct 19 10:55:23 2020 +0200
fuse: add error handling around HTTP errors (web API)
Closes T2709.See https://jenkins.softwareheritage.org/job/DFUSE/job/tests-on-diff/100/ for more details.