cli: make SWHIDParamType return SWHID type instead of string
ClosedPublic
Actions

Authored by haltode on Oct 5 2020, 10:23 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDMODbdfde828453a: cli: make SWHIDParamType return SWHID type instead of string

Diff Detail

Repository

rDMOD Data model

Branch

feature/SWHIDParamType-return-SWHID

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15872
Build 24426: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 24425: arc lint + arc unit

Event Timeline

haltode created this revision.Oct 5 2020, 10:23 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 5 2020, 10:23 AM

Build has FAILED

Patch application report for D4139 (id=14590)

Rebasing onto fe3ec554d7...

Current branch diff-target is up to date.

Changes applied before test

commit afbc757df808e94ffb8466498c7dd84f17a172ef
Author: Thibault Allançon <haltode@gmail.com>
Date:   Mon Oct 5 10:21:41 2020 +0200

    cli: make SWHIDParamType return SWHID type instead of string

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/143/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/143/console

Harbormaster failed remote builds in B15871: Diff 14590!Oct 5 2020, 10:24 AM

Use str() when comparing results.

Build is green

Patch application report for D4139 (id=14591)

Rebasing onto fe3ec554d7...

Current branch diff-target is up to date.

Changes applied before test

commit bdfde828453ad798932e7cd89aac74ec71efff5c
Author: Thibault Allançon <haltode@gmail.com>
Date:   Mon Oct 5 10:21:41 2020 +0200

    cli: make SWHIDParamType return SWHID type instead of string

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/144/ for more details.

Harbormaster completed remote builds in B15872: Diff 14591.Oct 5 2020, 10:30 AM

haltode mentioned this in D4064: Early FUSE implementation, with support for blob and directory objects.Oct 5 2020, 10:31 AM

vlorentz accepted this revision.Oct 5 2020, 10:35 AM

This revision is now accepted and ready to land.Oct 5 2020, 10:35 AM

Closed by commit rDMODbdfde828453a: cli: make SWHIDParamType return SWHID type instead of string (authored by haltode). · Explain WhyOct 5 2020, 10:38 AM

This revision was automatically updated to reflect the committed changes.

haltode added a commit: rDMODbdfde828453a: cli: make SWHIDParamType return SWHID type instead of string.

haltode mentioned this in rDFUSE2b688f8f3918: cli: use SWHIDParamType from swh.model.cli.Oct 7 2020, 3:12 PM