Converters: Fix uncaught exception
ClosedPublic
Actions

Authored by jbertran on May 30 2016, 3:53 PM.

Details

Reviewers

Group Reviewers

Commits

R65:52deecdbd984: Converter Tests: update to reflect the addition of fullname to person, revision…
R65:7e852430930e: Converters: add fullname to person and release converters. Fixes uncaught…
rDWAPPS52deecdbd984: Converter Tests: update to reflect the addition of fullname to person…
rDWAPPS7e852430930e: Converters: add fullname to person and release converters. Fixes uncaught…

Summary

Add fullname to list of dict values to decode

Test Plan

N/A

Diff Detail

Repository

rDWAPPS Web applications

Branch

FixConverters

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 142
Build 208: Software Heritage Python tests
Build 207: arc lint + arc unit

Event Timeline

jbertran updated this revision to Diff 112.May 30 2016, 3:53 PM

jbertran retitled this revision from to Converters: Fix uncaught exception.

jbertran updated this object.

jbertran edited the test plan for this revision. (Show Details)

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 30 2016, 3:53 PM

Nice catch.
Please, add the use case in the tests (from_person and from_release).

This revision now requires changes to proceed.May 30 2016, 4:00 PM

Converter Tests: update to reflect addition of attribute

ardumont accepted this revision.May 30 2016, 4:15 PM

ardumont edited edge metadata.

This revision is now accepted and ready to land.May 30 2016, 4:15 PM

Closed by commit rDWAPPS7e852430930e: Converters: add fullname to person and release converters. Fixes uncaught… (authored by jbertran). · Explain WhyJun 3 2016, 1:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

web/

ui/

converters.py

4 lines

tests/

test_converters.py

10 lines

Diff 113

View Options

swh/web/ui/converters.py