Differential D1411 Diff 4545 swh/deposit/migrations/0015_auto_20190411_1421.py

Changeset View

Standalone View

swh/deposit/migrations/0015_auto_20190411_1421.py

This file was added.

				# -- coding: utf-8 --
				# Generated by Django 1.11.16 on 2019-04-11 14:21
				from __future__ import unicode_literals

				from django.db import migrations, models


				class Migration(migrations.Migration):

				dependencies = [
				('deposit', '0014_auto_20180720_1221'),
				]

				operations = [
				migrations.AlterField(
				model_name='depositrequest',
				name='type',
				field=models.CharField(choices=[
				('archive', 'archive'),
				('metadata', 'metadata')], max_length=8),
				),
				migrations.DeleteModel(
				name='DepositRequestType',
				),
				]
				ardumontAuthorUnsubmitted Done Inline Actions Excerpt from irc discussion, this needs more work to actually migrate correctly in production. │16:29:26 +ardumont \| the only thing that makes me edgy is the db migration part │16:29:34 +ardumont \| other than that, i'm fine with that diff │16:29:45 +ardumont \| douardda: ^ │16:31:05 * \| ardumont documents himself on migration -> https://docs.djangoproject.com/en/2.1/topics/migrations/ │16:39:35 +douardda \| ardumont: so let's go │16:39:53 +olasd \| that migration won't work │16:40:16 +ardumont \| there you go! │16:40:17 +ardumont \| ;) │16:41:13 +ardumont \| will it destroy the existing data? │16:42:33 +ardumont \| i see that we can use `django-admin sqlmigrate` (to show the actual executed sql) and possibly `showmigrations` as well │16:43:18 +olasd \| the migration is trying to convert a foreign key (an integer) to a char field with choices │16:44:03 +olasd \| you're going to need to do it in 4 steps: add a new char field, update the data, remove the old field, rename the new field │16:44:28 +douardda \| ardumont olasd: I would have been surprised the migration of django being smart enough to handle this by its own │16:44:33 +douardda \| as I said │16:44:47 +ardumont \| indeed, david said as much yesterday ;) │16:45:03 +olasd \| well I'm just confirming that │16:45:13 +ardumont \| olasd: thx for the heads up │16:45:17 +ardumont \| quite │16:46:56 +ardumont \| well, he is/was dubious django could handle it itself, you are giving us a way forward now! │16:46:59 +ardumont \| so thx both │16:49:31 +ardumont \| > you're going to need to do it in 4 steps: add a new char field, update the data, remove the old field, rename the new field │16:49:49 +ardumont \| olasd: that means 4 modifications in the django model which generate each one a migration file, right? │16:50:23 +olasd \| not really, you should be able to do that in a single migration │16:50:26 +olasd \| +file ardumont: Excerpt from irc discussion, this needs more work to actually migrate correctly in production.
				ardumontAuthorUnsubmitted Done Inline Actions ok, so we can edit migration files to do thy bidding [1] You should rarely, if ever, need to edit migration files by hand, but it’s entirely possible to write them manually if you need to. Some of the more complex operations are not autodetectable and are only available via a hand-written migration, so don’t be scared about editing them if you have to. [1] https://docs.djangoproject.com/en/2.1/topics/migrations/ ardumont: ok, so we can edit migration files to do thy bidding [1] ``` You should rarely, if ever, need…
				ardumontAuthorUnsubmitted Done Inline Actions Better link to reference the quote is [2], last paragraph. Then [3] for `data migration` sounds interesting. To actually do the `update the data` step @olasd mentions \m/ [2] https://docs.djangoproject.com/en/2.1/topics/migrations/#migration-files [3] https://docs.djangoproject.com/en/2.1/topics/migrations/#data-migrations ardumont: Better link to reference the quote is [2], last paragraph. Then [3] for `data migration`…