Differential D8386 Diff 31284 swh/lister/fedora/lister.py

Changeset View

Standalone View

View Options

swh/lister/fedora/lister.py

This file was added.

anlambertUnsubmitted

Not Done

# See the AUTHORS file at the top-level directory of this distribution

# License: GNU General Public License version 3, or any later version

# See top-level LICENSE file for more information

from dataclasses import dataclass, field

import logging

from typing import Any, Dict, Iterator, List, Set, Type

from urllib.parse import urljoin

import repomd

from swh.scheduler.interface import SchedulerInterface

from swh.scheduler.model import ListedOrigin

from ..pattern import Lister

logger = logging.getLogger(__name__)

Release = int

Edition = str

PkgName = str

PkgVersion = str

FedoraOrigin = str

FedoraPageType = Type[repomd.Repo]

"""Each page is a list of packages from a given Fedora (release, edition) pair"""

def get_editions(release: Release) -> List[Edition]:

"""Get list of editions for a given release."""

if release < 20:

return ["Everything", "Fedora"]

elif release < 28:

return ["Everything", "Server", "Workstation"]

else:

return ["Everything", "Server", "Workstation", "Modular"]

@dataclass

class FedoraListerState:

"""State of Fedora lister"""

package_versions: Dict[PkgName, Set[PkgVersion]] = field(default_factory=dict)

"""Dictionary mapping a package name to all the versions found during

last listing"""

class FedoraLister(Lister[FedoraListerState, FedoraPageType]):

"""

List source packages for given Fedora releases.

The lister will create a snapshot for each package name from all its

available versions.

If a package snapshot is different from the last listing operation,

it will be sent to the scheduler that will create a loading task

to archive newly found source code.

Args:

scheduler: instance of SchedulerInterface

url: fedora package archives mirror URL

releases: list of fedora releases to process

"""

LISTER_NAME = "fedora"

def __init__(

self,

scheduler: SchedulerInterface,

instance: str = "fedora",

url: str = "https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/",

vlorentzUnsubmitted

Not Done

releases: Optional[List[Release]] = None,

- credentials: Optional[CredentialsType] = None,

super().__init__(

scheduler=scheduler,

url=url,

instance=instance,

- credentials=credentials, # TODO: should we remove this

+ credentials={},

)

self.releases = releases or ["34", "35", "36"]

vlorentz:

releases: List[Release] = [34, 35, 36],

super().__init__(

vlorentzUnsubmitted

Not Done

move the default list to the parameters so it is part of the doc (like the Debian lister)

vlorentz: move the default list to the parameters so it is part of the doc (like the Debian lister)

KShivenduAuthorUnsubmitted

Done

done.

but won't that make the default value mutable? (anti-pattern)

KShivendu: done. but won't that make the default value mutable? (anti-pattern)

scheduler=scheduler,

url=url,

instance=instance,

credentials={},

)

self.releases = releases

self.listed_origins: Dict[FedoraOrigin, ListedOrigin] = {}

"will hold all listed origins info"

self.sent_origins: Set[FedoraOrigin] = set()

vlorentzUnsubmitted

Done

use docstrings so they can be documented by Sphinx

vlorentz: use docstrings so they can be documented by Sphinx

KShivenduAuthorUnsubmitted

Done

good idea!

KShivendu: good idea!

"""will contain origin urls that have already been listed

in a previous page (fedora release)"""

self.origins_to_update: Dict[FedoraOrigin, ListedOrigin] = {}

"""will contain already listed package info that need to be

sent to the scheduler for update in the commit_page method"""

self.package_versions: Dict[PkgName, Set[PkgVersion]] = {}

"will contain the lister state after a call to run"

def state_from_dict(self, d: Dict[str, Any]) -> FedoraListerState:

return FedoraListerState(package_versions={k: set(v) for k, v in d.items()})

def state_to_dict(self, state: FedoraListerState) -> Dict[str, Any]:

return {k: list(v) for k, v in state.package_versions.items()}

anlambertUnsubmitted

Not Done

You can remove these instance variables. I guess you inspire from the debian lister to implement the fedora one
but since then debian lister has been updated in rDLS5426883c49ce0fc4a442b705ae573f868b9f7a62 to
something simpler as base lister class gained the ability to return accurate origin counts in the run method.

anlambert: You can remove these instance variables. I guess you inspire from the debian lister to…

def page_request(self, release: Release, edition: Edition) -> FedoraPageType:

"""Return parsed packages for a given fedora release."""

index_url = urljoin(

self.url,

f"{release}/{edition}/source/SRPMS/"

if release < 24

else f"{release}/Everything/source/tree/",

)

repo = repomd.load(index_url) # throws error if no repomd.xml is not found

logging.debug(

"Fetched metadata from url: %s, found %d packages", index_url, len(repo)

)

# TODO: Extract more fields like "provides" and "requires" from *primary.xml

# as extrinsic metadata using the pkg._element.findtext method

vlorentzUnsubmitted

Not Done

That's consistent with the Debian lister, but IIRC using deb:// has some issues . @olasd Does this rind a bell?

vlorentz: That's consistent with the Debian lister, but IIRC using `deb://` has some issues . @olasd Does…

return repo

anlambertUnsubmitted

Not Done

else f"{release}/{edition}/source/tree/",

anlambert: ```lang=python else f"{release}/{edition}/source/tree/", ```

def get_pages(self) -> Iterator[FedoraPageType]:

"""Return an iterator on parsed fedora packages, one page per (release, edition) pair"""

# Dirs that don't contain .rpm files:

anlambertUnsubmitted

Not Done

s/logging/logger/

anlambert: s/logging/logger/

# Docker,CloudImages,Atomic*,Spins,Live,Cloud_Atomic,Silverblue

for release in self.releases:

for edition in get_editions(release):

logger.debug("Listing fedora release %s edition %s", release, edition)

self.current_release = release

self.current_edition = edition

yield self.page_request(release, edition)

def origin_url_for_package(self, package_name: PkgName) -> FedoraOrigin:

"""Return the origin url for the given package"""

return f"rpm://{self.instance}/packages/{package_name}"

def get_origins_from_page(self, page: FedoraPageType) -> Iterator[ListedOrigin]:

"""Convert a page of fedora package sources into an iterator of ListedOrigin."""

anlambertUnsubmitted

Not Done

You should handle 404 errors here as it exists cases where no packages metadata are available for a given fedora release and edition.
For instance:

try:
    yield self.page_request(release, edition)
except HTTPError as http_error:
    if http_error.getcode() == 404:
        logger.debug(
            "No packages metadata found for fedora release %s edition %s",
            release,
            edition,
        )
        continue
    raise

anlambert: You should handle 404 errors here as it exists cases where no packages metadata are available…

assert self.lister_obj.id is not None

origins_to_send = {}

self.origins_to_update = {}

anlambertUnsubmitted

Not Done

I think it is better to use a real HTTPS origin URL in the form https://packages.fedoraproject.org/pkgs/{package_name} instead of such URL with non standard scheme.
I know we used something similar in the debian lister but thinking it back it was a mistake (see T4632#98164).

anlambert: I think it is better to use a real HTTPS origin URL in the form `https://packages.fedoraproject.

# iterate on each package's metadata

for pkg_metadata in page:

# extract package metadata

package_name = pkg_metadata.name

package_version = pkg_metadata.version

package_last_updated = pkg_metadata.build_time

anlambertUnsubmitted

Not Done

to remove

anlambert: to remove

package_download_path = pkg_metadata.location

# build origin url

origin_url = self.origin_url_for_package(package_name)

# create package version key as expected by the fedora (rpm) loader

# TODO: could use pkg.release instead of self.current_release

package_version_key = (

f"{self.current_release}/{self.current_edition}/{package_version}"

)

# this is the first time a package is listed

if origin_url not in self.listed_origins:

# create a ListedOrigin object for it that can be later

# updated with new package versions info

self.listed_origins[origin_url] = ListedOrigin(

lister_id=self.lister_obj.id,

url=origin_url,

visit_type="rpm",

extra_loader_arguments={"packages": {}},

last_update=package_last_updated,

)

vlorentzUnsubmitted

Done

# to the rpm loader

- self.listed_origins[origin_url].extra_loader_arguments["packages"].update(

- {

- package_version_key: {

+ self.listed_origins[origin_url].extra_loader_arguments

+ extra_loader_arguments["packages"][package_version_key] = {

"name": package_name,

"version": package_version,

}

)

# add package version key to the set of found versions

more idiomatic IMO

vlorentz: more idiomatic IMO

# origin will be yielded at the end of that method

origins_to_send[origin_url] = self.listed_origins[origin_url]

# init set that will contain all listed package versions

self.package_versions[package_name] = set()

anlambertUnsubmitted

Not Done

You should set the last_update parameter of ListedOrigin constructor to package_build_time here.
Setting a last update date to ListedOrigin instances is quite important as it really improves the scheduling
of loading tasks for fedora packages, meaning only packages with new versions since last listing will be scheduled
to be loaded again.

anlambert: You should set the `last_update` parameter of `ListedOrigin` constructor to…

# package has already been listed in a previous or current page (release)

elif origin_url not in origins_to_send:

# if package has been listed in previously, its new versions

# will be added to its ListedOrigin object but the update will

# be sent to the scheduler in the commit_page method

self.origins_to_update[origin_url] = self.listed_origins[origin_url]

# update package versions data in parameter that will be provided

# to the rpm loader

self.listed_origins[origin_url].extra_loader_arguments["packages"][

package_version_key

] = {

anlambertUnsubmitted

Not Done

replace this block with:

origins_to_send[origin_url] = self.listed_origins[origin_url]

anlambert: replace this block with: ```lang=python origins_to_send[origin_url] = self.listed_origins…

"name": package_name,

"version": package_version,

"url": urljoin(page.baseurl, package_download_path),

"release": self.current_release,

}

# add package version key to the set of found versions

self.package_versions[package_name].add(package_version_key)

# update already counted origins with changes since last page

self.sent_origins.update(origins_to_send.keys())

logger.debug(

"Found %s new packages, %s packages with new versions.",

len(origins_to_send),

len(self.origins_to_update),

)

anlambertUnsubmitted

Not Done

After updating package versions, you should also update the last_update value of associated ListedOrigin:

if package_build_time > self.listed_origins[origin_url].last_update:
    self.listed_origins[origin_url].last_update = package_build_time

As in the debian lister, you can also discard ListedOrigin instances with no new versions to be sent to the scheduler:

# package has already been listed during a previous listing process
if package_name in self.state.package_versions:
    new_versions = (
        self.package_versions[package_name]
        - self.state.package_versions[package_name]
    )
    # no new versions so far, no need to send the origin to the scheduler
    if not new_versions:
        origins_to_send.pop(origin_url, None)

anlambert: After updating package versions, you should also update the `last_update` value of associated…

logger.debug(

"Current total number of listed packages is equal to %s.",

anlambertUnsubmitted

Not Done

to remove

anlambert: to remove

len(self.listed_origins),

)

yield from origins_to_send.values()

def get_origins_to_update(self) -> Iterator[ListedOrigin]:

anlambertUnsubmitted

Not Done

Replace this debug log with:

logger.debug(
     "Found %s packages to update (new ones or packages with new versions).",
    len(origins_to_send),
)

anlambert: Replace this debug log with: ```lang=python logger.debug( "Found %s packages to update…

yield from self.origins_to_update.values()

def commit_page(self, page: FedoraPageType):

"""Send to scheduler already listed origins where new versions have been found

in current page."""

self.send_origins(self.get_origins_to_update())

def finalize(self):

# set mapping between listed package names and versions as lister state

self.state.package_versions = self.package_versions

self.updated = len(self.sent_origins) > 0

anlambertUnsubmitted

Not Done

to remove

anlambert: to remove

anlambertUnsubmitted

Not Done

self.updated = len(self.listed_origins) > 0

anlambert: ```lang=python self.updated = len(self.listed_origins) > 0 ```