Page MenuHomeSoftware Heritage
Create Task
Maniphest T3367

scheduler: Separate scheduling save code now tasks from the recurrent tasks
Closed, MigratedEdits Locked
Actions

Description

It happens that the recurrent tasks get stuck. It has been worked around but the *main* issue is not yet understood.

Given the save code now expectancy "make it reliable and fast", they must be scheduled independently from the rest.
That should alleviate the current recurring pattern of the apparent "stuckness" of the save code now [1]

Implementation wise, that means having another scheduler runner separated from the current one whose concern
would be to deal with save code now only. The actual one being modified to no longer grab tasks for the save code now.

[1] It is stuck but it's not only the save code now... It's *mostly* all tasks.

Related to T3361

Revisions and Commits

rDSCH Scheduling utilities
D5826rDSCHc7707b5c836c runner: Separate scheduling tasks with and without priority concern
D5846rDSCH21c4279b9998 Refactor and extract a get_available_slots utility
rDENV Development environment
D5851rDENVca6a6c8a235b docker: Explicit the scheduler runner for save-code-now
rSPSITE puppet-swh-site
D5854rSPSITE232088a7b74a scheduler: Drop clean up instructions
D5854rSPSITEb9de3f4ede43 Install the scheduler-runner-priority in scheduler nodes

Related Objects

Event Timeline

ardumont triaged this task as Normal priority.Jun 7 2021, 4:51 PM
ardumont created this task.
ardumont updated the task description. (Show Details)Jun 7 2021, 4:54 PM
ardumont added projects: Save Code Now, Scheduling utilities.
ardumont updated the task description. (Show Details)
ardumont added a revision: D5826: runner: Separate scheduling tasks with and without priority concerns.Jun 8 2021, 5:39 PM
ardumont added a revision: D5846: Refactor and extract a get_available_slots utility.Jun 10 2021, 12:17 PM
ardumont added a commit: rDSCH21c4279b9998: Refactor and extract a get_available_slots utility.Jun 10 2021, 12:25 PM
ardumont added a revision: D5851: docker: Explicit the scheduler runner for save-code-now.Jun 10 2021, 3:22 PM
ardumont added a commit: rDSCHc7707b5c836c: runner: Separate scheduling tasks with and without priority concern.Jun 10 2021, 4:01 PM
ardumont added a commit: rDENVca6a6c8a235b: docker: Explicit the scheduler runner for save-code-now.
ardumont claimed this task.Jun 11 2021, 10:11 AM
ardumont added a revision: D5854: Install the scheduler-runner-priority in scheduler nodes.Jun 11 2021, 11:21 AM
ardumont added a commit: rSPSITEb9de3f4ede43: Install the scheduler-runner-priority in scheduler nodes.Jun 11 2021, 11:41 AM
ardumont added a commit: rSPSITE232088a7b74a: scheduler: Drop clean up instructions.
ardumont added a comment.Jun 11 2021, 11:58 AM

Deployed first yesterday on staging (manually) to check the behavior.
Everything was fine.

So finalized the puppet part and deployed on production.

So now, in effect, we have 2 instances of existing scheduler runners [1]

One for the existing all the tasks not disabled (old behavior) which will focus only on tasks without any priority (the default).
Another for the tasks with priority (only the save code now uses those).

Closing now.

[1] well a bit more with the next-gen ones but out of scope here.

ardumont closed this task as Resolved.Jun 11 2021, 11:58 AM
ardumont added a project: System administration.
ardumont moved this task from Backlog to deployed/landed/monitoring on the System administration board.
ardumont moved this task from deployed/landed/monitoring to done on the System administration board.
ardumont mentioned this in T3361: "Save code now" seems to be stuck.Jun 11 2021, 12:02 PM
gitlab-migration changed the task status from Resolved to Migrated.Oct 19 2022, 6:02 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal