Diffusion puppet-puppet-kafka 75c29abb538d

Refactor unit tests (#313)
75c29abb538d
Actions

Description

Refactor unit tests (#313)

Refactor unit tests in favor of on_supported_os()

Fix legacy facts

Use variable os_facts to prevent overlap

Use if/unless syntax for better readability

Refactor service related unit tests

Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>

Replace common_params with calling super

Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>

Details

Provenance

Dennis Hoppe <github@debian-solutions.de>	Authored on May 28 2020, 11:36 AM
GitHub <noreply@github.com>	Committed on May 28 2020, 11:36 AM
vsellier	Pushed on Sep 25 2020, 11:27 AM

Parents

R143:c0040b2c0304: Merge pull request #304 from dhoppe/add_reference

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed R143:75c29abb538d: Refactor unit tests (#313) (authored by Dennis Hoppe <github@debian-solutions.de>).May 28 2020, 11:36 AM

Changes (8)

Path

Size

manifests/

mirror/

service.pp

spec/

classes/

defines/

shared_examples_param_validation.rb

R143:75c29abb538d

View Options

manifests/mirror/service.pp

View Options

spec/classes/broker_spec.rb

View Options

spec/classes/consumer_spec.rb

View Options

spec/classes/init_spec.rb

View Options

spec/classes/mirror_spec.rb

View Options

spec/classes/producer_spec.rb

View Options

spec/defines/topic_spec.rb

View Options

spec/shared_examples_param_validation.rb

Refactor unit tests (#313)75c29abb538dActions

Description

Details

Event Timeline

Changes (8)

R143:75c29abb538d

manifests/mirror/service.pp

spec/classes/broker_spec.rb

spec/classes/consumer_spec.rb

spec/classes/init_spec.rb

spec/classes/mirror_spec.rb

spec/classes/producer_spec.rb

spec/defines/topic_spec.rb

spec/shared_examples_param_validation.rb

Refactor unit tests (#313)
75c29abb538d
Actions