Differential D9

T292 - Open /directory/<sha1_git>/[<path>/] api route
ClosedPublic
Actions

Authored by jbertran on Apr 29 2016, 3:59 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Maniphest Tasks

T292: Open /api/1/directory/<sha1_git>/[<path>/] api

Commits

R65:73cf90203b8a: api: update /directory/ route to allow relative navigation from given directory…
R65:bbe20ca00a27: api tests: update to reflect changes in /directory/ route management
R65:1cb9b0825f22: update docstring for directory/<sha1_git>/[<path>/] api route
R65:3afd0eeb9e19: service tests: add tests for relative directory navigation
R65:f0cc036b0570: service: provide a method to navigate to directory entry given relative path…
rDWAPPS1cb9b0825f22: update docstring for directory/<sha1_git>/[<path>/] api route
rDWAPPSbbe20ca00a27: api tests: update to reflect changes in /directory/ route management
rDWAPPS3afd0eeb9e19: service tests: add tests for relative directory navigation
rDWAPPS73cf90203b8a: api: update /directory/ route to allow relative navigation from given…
rDWAPPSf0cc036b0570: service: provide a method to navigate to directory entry given relative path…

Summary

Fixes T292

Test Plan

Tests updated accordingly.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbertran updated this revision to Diff 19.Apr 29 2016, 3:59 PM

jbertran added a task: T292: Open /api/1/directory/<sha1_git>/[<path>/] api.

jbertran retitled this revision from to T292 - Open /directory/<sha1_git>/[<path>/] api route.

jbertran updated this object.

jbertran edited the test plan for this revision. (Show Details)

jbertran added a reviewer: zack.

Herald added a reviewer: Developers. · View Herald TranscriptApr 29 2016, 3:59 PM

please resubmit, pushing to the staging repository (for CI) should work this time

This revision now requires changes to proceed.Apr 29 2016, 4:03 PM

zack accepted this revision.Apr 29 2016, 4:06 PM

zack edited edge metadata.

This revision is now accepted and ready to land.Apr 29 2016, 4:06 PM

diff: fix origin problem

This revision now requires review to proceed.Apr 29 2016, 4:10 PM

update docstring for directory/<sha1_git>/[<path>/] api route

only one nit above, feel free to submit it as a separate review request

swh/web/ui/views/api.py
657 ↗	(On Diff #21)	I know it's unrelated to your changes, but please remove the default value here (in a separate commit). Api end points should not have default hard-coded values.

This revision is now accepted and ready to land.Apr 29 2016, 4:20 PM

Closed by commit rDWAPPSf0cc036b0570: service: provide a method to navigate to directory entry given relative path… (authored by jbertran). · Explain WhyApr 29 2016, 4:35 PM

This revision was automatically updated to reflect the committed changes.

jbertran marked an inline comment as done.

zack edited edge metadata.May 30 2016, 3:17 PM

zack changed the visibility from "All Users" to "Public (No Login Required)".

Revision Contents
Changeset List

Path

Size

swh/

web/

ui/

24 lines

Diff 23

swh/web/ui/service.py

Loading...