This is currently doing nothing, but prepare for actually changing the
generic validator into faster specialized variants.
Details
Details
- Reviewers
- None
- Group Reviewers
Reviewers
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Branch
- DXXXX
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 31684 Build 49570: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 49569: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D8526 (id=30707)
Could not rebase; Attempt merge onto 9ce6feb9d6...
Updating 9ce6feb..923b61e Fast-forward CONTRIBUTORS | 1 + swh/model/from_disk.py | 33 +++++++++++++++++++++++++--- swh/model/git_objects.py | 14 +++++++----- swh/model/model.py | 57 +++++++++++++++++++++++++++++------------------- 4 files changed, 74 insertions(+), 31 deletions(-)
Changes applied before test
commit 923b61ed334613b268229b4789810dd332100ccf Author: Pierre-Yves David <pierre-yves.david@ens-lyon.org> Date: Tue Sep 20 15:48:55 2022 +0200 model: prepare the filtering of type_validator into something faster This is currently doing nothing, but prepare for actually changing the generic validator into faster specialized variants. commit ad7774bec2b48af2ee74d59e34dc6de02751896a Author: Pierre-Yves David <pierre-yves.david@ens-lyon.org> Date: Thu Sep 22 18:24:46 2022 +0200 from_disk: skip intermediate dictionnary creation when building model This should speed things up. commit 41500db7ea8856f75812f4fe8d8a66c6fdc43a82 Author: Pierre-Yves David <pierre-yves.david@ens-lyon.org> Date: Thu Sep 22 18:12:43 2022 +0200 model: avoid another extra creation of Model object Do not create model object while sorting entry before creating model object. commit 36185705f1805465d565b00b0df917b0e4f1c8e4 Author: Pierre-Yves David <pierre-yves.david@ens-lyon.org> Date: Tue Sep 20 14:26:17 2022 +0200 from_disk: only build a model object once Before this change, a Directory object was built to compute the `id` of we fed to the Directory object we built for `to_model`.
See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/512/ for more details.