Page MenuHomeSoftware Heritage

graphql: Reference new search backend for latest graphql version
ClosedPublic

Authored by ardumont on Aug 26 2022, 3:10 PM.

Details

Summary

Related to T4464

Test Plan

This does the job:

$ helm install --values values-swh-application-versions.yaml  --values swh/values/default.yaml --values swh/values/staging.yaml swh-test swh --dry-run --debug --set namespace=test 2>&1 | grep -A10 config.yml | head
  config.yml: |
    search:
      cls: remote
      url: http://search0.internal.staging.swh.network:5010
    storage:
      cls: remote
      url: http://webapp.internal.staging.swh.network:5002
    debug: yes

    server-type: wsgi

Diff Detail

Repository
R260 Helm charts for swh packages
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier added a subscriber: vsellier.
vsellier added inline comments.
swh/templates/graphql/configmap.yaml
12–13

the presence of the storage or search dicts should be tested to avoid a NPE.
I suppose none of them is mandatory?

This revision now requires changes to proceed.Aug 26 2022, 3:39 PM
swh/templates/graphql/configmap.yaml
12–13

the presence of the storage or search dicts should be tested to avoid a NPE.

you mean wrap the configuration writing with conditionals, right?

NPE as in "Null Pointer Exception"? (such a java dude ;)

I suppose none of them is mandatory?

storage must be otherwise i don't know how the server could reply something. You are
probably right for search though.

i'll attend to it.

Adapt configuration to use a backends key which reference the possible graphql backends

ardumont retitled this revision from graphql: Reference new search configuration key to graphql: Reference new search backend for latest graphql version.
This revision is now accepted and ready to land.Aug 26 2022, 4:43 PM