Page MenuHomeSoftware Heritage

Add chart to deploy graphql
ClosedPublic

Authored by vsellier on Wed, Jun 1, 8:46 AM.

Details

Diff Detail

Repository
R260 Helm charts for swh packages
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier created this revision.

Remove testing values file

update storage default url to match a local service deployed on the cluster

ardumont added inline comments.
swh-graphql/README.md
5
swh-graphql/templates/deployment.yaml
45

is that the default value the graphql module is using?

I don't see any env variable declaring that path for the gunicorn service to work with.

swh-graphql/values.yaml
21

(curious) Why would there not be one?

25–28

lgtm

couple of questions inline.

This revision is now accepted and ready to land.Wed, Jun 1, 10:19 AM

fix typos according to the feedback

swh-graphql/templates/deployment.yaml
45

yes, it's hardcoded in the entrypoint of the docker image

swh-graphql/values.yaml
21

A user may want to use an unsupported ingress controller (traefik or whatever) or may have no ingress controller at all in his cluster and for test purpose, just the service and kubectl proxy can be enough.

This revision was automatically updated to reflect the committed changes.