Differential D7846

[swh-graphql] Prepare the docker image generation
ClosedPublic
Actions

Authored by vsellier on May 18 2022, 11:37 AM.

Details

Reviewers

ardumont

Group Reviewers

System administrators

Maniphest Tasks

T4134: Package the graphql service

Commits

R259:0f0cf6c8874d: Add the Dockerfile for the swh-graphql application
R259:21bc668b25b6: Add missing swh-graphql dependencies

Summary

Add missing swh-graphql dependencies
Add the Dockerfile for the swh-graphql application

As it's the first application, everything is in a uniq Dockerfile.
We'll see later if some parts can be factorized

Related to T4134

Test Plan

docker build -t swh-graphql .
docker run -ti --rm -v config.yml:/etc/swh/config.yml -p 5013:5013 swh-graphql

Diff Detail

Repository

R259 Software Heritage virtual environment packaging manifests

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier requested review of this revision.May 18 2022, 11:37 AM

vsellier created this revision.

Harbormaster completed remote builds in B29445: Diff 28342.May 18 2022, 11:37 AM

vsellier added inline comments.May 18 2022, 11:39 AM

apps/swh-graphql/requirements-frozen.txt
8	this one is weird. I had to remove it manually According to https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1635463 it seems it related to the local pip environment but I didn't succeed to fix it.

ardumont added a subscriber: ardumont.May 18 2022, 11:42 AM

ardumont added inline comments.

apps/swh-graphql/requirements.txt
7	why adding "itself" to the requirements?

vsellier added inline comments.May 18 2022, 11:46 AM

apps/swh-graphql/requirements.txt
7	to also froze this dependency. So when we will tag swh-graphql-xxx, we will have the graphql version fixed for the tag

ardumont added inline comments.May 18 2022, 11:50 AM

apps/swh-graphql/requirements.txt
7	makes sense, thx.

lgtm, thx.

This revision is now accepted and ready to land.May 18 2022, 11:59 AM

Closed by commit R259:21bc668b25b6: Add missing swh-graphql dependencies (authored by vsellier). · Explain WhyMay 18 2022, 1:34 PM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: R259:21bc668b25b6: Add missing swh-graphql dependencies.

vsellier added a commit: R259:0f0cf6c8874d: Add the Dockerfile for the swh-graphql application.

Revision Contents
Changeset List

Path

Size

apps/

swh-graphql/

requirements-frozen.txt

80 lines

requirements.txt

1 line

Diff 28346

View Options

apps/swh-graphql/requirements-frozen.txt