Paths

Table of Contentst

Differential D7826

Move the prometheus statsd exporter to use the upstream tarball
ClosedPublic
Actions

Authored by olasd on May 12 2022, 8:22 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

System administrators

Maniphest Tasks

T4225: Deploy a more recent version of prometheus-statsd-exporter on all nodes

Commits

rSPSITE899dca0ec287: Move the prometheus statsd exporter to use the upstream tarball

Summary

Related to T4225

Test Plan

Tested the upgrade from the Debian package to the tarball in a Vagrant VM

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.May 12 2022, 8:22 PM

Herald added a reviewer: System administrators. · View Herald TranscriptMay 12 2022, 8:22 PM

olasd requested review of this revision.May 12 2022, 8:22 PM

Harbormaster completed remote builds in B29364: Diff 28258.May 12 2022, 8:22 PM

LGTM, just 2 non-blocking questions inline

site-modules/profile/manifests/prometheus/statsd.pp
42	Shouldn't the service be notified in case of an update?
44	Is this file declaration is just to avoid an override somewhere or for something else I'm missing?

This revision is now accepted and ready to land.May 13 2022, 10:01 AM

olasd added inline comments.May 13 2022, 10:08 AM

site-modules/profile/manifests/prometheus/statsd.pp
42	If the file exists it will never be updated (that's what `creates =>` makes sure of). If the version number changes, the filename will change and the unit file will be updated, triggering a refresh of the service.
44	It allows actually requiring the `File` resource in the systemd unit definition, instead of having to use the archive's temporary filename.

Closed by commit rSPSITE899dca0ec287: Move the prometheus statsd exporter to use the upstream tarball (authored by olasd). · Explain WhyMay 13 2022, 10:16 AM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rSPSITE899dca0ec287: Move the prometheus statsd exporter to use the upstream tarball.

Revision Contents
Changeset List

Path

Size

data/

common/

2 lines

site-modules/

profile/

manifests/

prometheus/

83 lines

templates/

prometheus/

statsd/

prometheus-statsd-exporter.defaults.erb

prometheus-statsd-exporter.service.erb

14 lines

Diff 28260

data/common/common.yaml

Loading...

site-modules/profile/manifests/prometheus/statsd.pp

Loading...

site-modules/profile/templates/prometheus/statsd/prometheus-statsd-exporter.defaults.erb

Loading...

site-modules/profile/templates/prometheus/statsd/prometheus-statsd-exporter.service.erb

Loading...