Page MenuHomeSoftware Heritage

Move the prometheus statsd exporter to use the upstream tarball
ClosedPublic

Authored by olasd on Thu, May 12, 8:22 PM.

Details

Summary

Related to T4225

Test Plan

Tested the upgrade from the Debian package to the tarball in a Vagrant VM

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd requested review of this revision.Thu, May 12, 8:22 PM
vsellier added a subscriber: vsellier.

LGTM, just 2 non-blocking questions inline

site-modules/profile/manifests/prometheus/statsd.pp
42

Shouldn't the service be notified in case of an update?

44

Is this file declaration is just to avoid an override somewhere or for something else I'm missing?

This revision is now accepted and ready to land.Fri, May 13, 10:01 AM
site-modules/profile/manifests/prometheus/statsd.pp
42

If the file exists it will never be updated (that's what creates => makes sure of).

If the version number changes, the filename will change and the unit file will be updated, triggering a refresh of the service.

44

It allows actually requiring the File resource in the systemd unit definition, instead of having to use the archive's temporary filename.