Page MenuHomeSoftware Heritage
Differential D78

archiver: change the master's storage to an object storage
ClosedPublic
Actions

Authored by ardumont on Jul 20 2016, 5:03 PM.

Active Operations

    Operation 2 Land Revision
    • The push failed. This usually indicates that the change is breaking some rules or some custom commit hook has failed.
    • ·Show Details

Details

Reviewers
qcampos
Group Reviewers
Reviewers
Maniphest Tasks
T499: Change the swh.storage of the archiver to a swh.objstorage
Commits
rDSTOCf500ca2a0612: archiver: change the master's storage to an object storage
R65:f500ca2a0612: archiver: change the master's storage to an object storage
rDARCc2483d7a3c12: archiver: change the master's storage to an object storage
rDSTOf500ca2a0612: archiver: change the master's storage to an object storage
Summary

Related T499

test.archiver: update the tests to follow changes in the archiver

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

qcampos updated this revision to Diff 255.Jul 20 2016, 5:03 PM
qcampos added a task: T499: Change the swh.storage of the archiver to a swh.objstorage.
qcampos retitled this revision from to archiver: change the master's storage to an object storage.
qcampos updated this object.
qcampos edited the test plan for this revision. (Show Details)
qcampos added a reviewer: ardumont.
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 20 2016, 5:03 PM
ardumont edited edge metadata.Jul 20 2016, 5:52 PM

Other than the missed parameter to remove, this seems ok.
I'll fix it myself.

As a note, that would not have shocked me if you have left the name storage instead of renaming it to storage.

swh/storage/archiver/director.py
280

You forgot to remove the argument dbconn_storage here.

ardumont accepted this revision.Jul 20 2016, 6:01 PM
ardumont edited edge metadata.
This revision is now accepted and ready to land.Jul 20 2016, 6:01 PM
ardumont commandeered this revision.Jul 20 2016, 6:10 PM
ardumont edited reviewers, added: qcampos; removed: ardumont.
This revision now requires review to proceed.Jul 20 2016, 6:10 PM
Closed by commit rDSTOf500ca2a0612: archiver: change the master's storage to an object storage (authored by qcampos, committed by ardumont). · Explain WhyJul 20 2016, 6:59 PM
This revision was automatically updated to reflect the committed changes.
ardumont mentioned this in rDSTOf500ca2a0612: archiver: change the master's storage to an object storage.
ardumont added a comment.Jul 20 2016, 7:01 PM

After some fights with phab, arcanist, etc...

I finally successfully merged it directly.
I've patched my local swh-storage and merged the resulting branch to master.

Thanks @qcampos ^^

ardumont mentioned this in rDSTOc779f05b2fcf: Fix - Remove unused parameter.Jul 20 2016, 7:04 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
archiver/
20 lines
128 lines
8 lines
53 lines
tests/
14 lines

Diff 256

View Options

swh/storage/archiver/copier.py

Loading...
View Options

swh/storage/archiver/director.py

Loading...
View Options

swh/storage/archiver/tasks.py

Loading...
View Options

swh/storage/archiver/worker.py

Loading...
View Options

swh/storage/tests/test_archiver.py

Loading...
About · Developer information · Legal