Page MenuHomeSoftware Heritage

archiver: change the master's storage to an object storage
ClosedPublic

Authored by ardumont on Jul 20 2016, 5:03 PM.

Active Operations

    Operation 2 Land Revision
    • The push failed. This usually indicates that the change is breaking some rules or some custom commit hook has failed.
    • ·Show Details

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

qcampos updated this revision to Diff 255.Jul 20 2016, 5:03 PM
qcampos retitled this revision from to archiver: change the master's storage to an object storage.
qcampos updated this object.
qcampos edited the test plan for this revision. (Show Details)
qcampos added a reviewer: ardumont.
ardumont edited edge metadata.Jul 20 2016, 5:52 PM

Other than the missed parameter to remove, this seems ok.
I'll fix it myself.

As a note, that would not have shocked me if you have left the name storage instead of renaming it to storage.

swh/storage/archiver/director.py
280

You forgot to remove the argument dbconn_storage here.

ardumont accepted this revision.Jul 20 2016, 6:01 PM
ardumont edited edge metadata.
This revision is now accepted and ready to land.Jul 20 2016, 6:01 PM
ardumont commandeered this revision.Jul 20 2016, 6:10 PM
ardumont edited reviewers, added: qcampos; removed: ardumont.
This revision now requires review to proceed.Jul 20 2016, 6:10 PM
This revision was automatically updated to reflect the committed changes.

After some fights with phab, arcanist, etc...

I finally successfully merged it directly.
I've patched my local swh-storage and merged the resulting branch to master.

Thanks @qcampos ^^