Paths

Table of Contentst

Differential D6840

terraform: update the proxmox provider
ClosedPublic
Actions

Authored by vsellier on Dec 15 2021, 12:55 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

System administrators

Maniphest Tasks

T3806: terraform: upgrade proxmox provider to last release

Commits

rSPRE5cf38552a3b5: terraform: update the proxmox provider

Summary

This upgrade expose several new options of the vms.
They need to be opened as variables to match the real configuration
of the vms on proxmox.

Related to T3806

Test Plan

terraform init --upgrade
terraform plan

Diff Detail

Repository

rSPRE sysadm-provisioning

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier requested review of this revision.Dec 15 2021, 12:55 PM

vsellier created this revision.

Harbormaster completed remote builds in B25644: Diff 24795.Dec 15 2021, 12:55 PM

lgtm

I've focused on the terraform "manifest".

Couple of non-blocking questions inline (i think ;)

proxmox/terraform/admin/terraform.tfstate
187–189	is that change ok ^?
proxmox/terraform/modules/node/main.tf
63	we no longer need that information then?

This revision is now accepted and ready to land.Dec 15 2021, 2:47 PM

vsellier added inline comments.Dec 15 2021, 3:10 PM

proxmox/terraform/admin/terraform.tfstate
187–189	yes it seems it is. https://pve.proxmox.com/wiki/Storage rbd is well the type of the 'proxmox' storage The cephfs type is used by `proxmox-cephfs`. probably a bug on the earlier version of the provisionner
proxmox/terraform/modules/node/main.tf
63	good catch

Remove last references to storage_type

Harbormaster completed remote builds in B25651: Diff 24802.Dec 15 2021, 3:19 PM

Closed by commit rSPRE5cf38552a3b5: terraform: update the proxmox provider (authored by vsellier). · Explain WhyDec 15 2021, 3:20 PM

This revision was automatically updated to reflect the committed changes.

vsellier added a commit: rSPRE5cf38552a3b5: terraform: update the proxmox provider.

Revision Contents
Changeset List

Path

Size

proxmox/

terraform/

46 lines

admin/

4 lines

terraform.tfstate

152 lines

modules/

node/

9 lines

57 lines

production/

2 lines

terraform.tfstate

312 lines

staging/

120 lines

terraform.tfstate

832 lines

13 lines

Diff 24803

proxmox/terraform/README.md

Loading...

proxmox/terraform/admin/admin.tf

Loading...

proxmox/terraform/admin/terraform.tfstate

Loading...

proxmox/terraform/modules/node/main.tf

Loading...

proxmox/terraform/modules/node/variables.tf

Loading...

proxmox/terraform/production/production.tf

Loading...

proxmox/terraform/production/terraform.tfstate

Loading...

proxmox/terraform/staging/staging.tf

Loading...

proxmox/terraform/staging/terraform.tfstate

Loading...

proxmox/terraform/versions.tf

Loading...