Open a log route that takes (upcoming) navigation breadcrumbs
into account.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- R65:f3cf76370ef7: service: minor fixes, switch to map objects instead of lists
R65:51b7f73039e6: backend: provide lookup for a list of revision sha1s
R65:153b3572d378: Service: provide lookup of a list of revision sha1s
R65:fa57b641d05f: Api: open '/revision/<sha1>/prev/<sha1list>/' route for nav breadcrumbs
rDWAPPSf3cf76370ef7: service: minor fixes, switch to map objects instead of lists
rDWAPPSfa57b641d05f: Api: open '/revision/<sha1>/prev/<sha1list>/' route for nav breadcrumbs
rDWAPPS153b3572d378: Service: provide lookup of a list of revision sha1s
rDWAPPS51b7f73039e6: backend: provide lookup for a list of revision sha1s
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
swh/web/ui/backend.py | ||
---|---|---|
182 | I don't remember, do we absolutely need to check the length? | |
swh/web/ui/service.py | ||
236 ↗ | (On Diff #216) | What about lookup_revisions? |
255 ↗ | (On Diff #216) | you could use map or a generator here. In general, personally, i avoid round-trips if i can avoid it. |
258 ↗ | (On Diff #216) | You could also use map map(converters.from_revisions, revisions) or a generator ^^ (converters.from_revision(x) for x in revisions) The superior layer does the translation before serializing anyway. Impact: You'll need to force the lazyness in your tests for this function (by wrapping your call in a list for example). |
swh/web/ui/views/api.py | ||
705 ↗ | (On Diff #216) | children path |
723 ↗ | (On Diff #216) | if not prev_sha1s: |
725 ↗ | (On Diff #216) | you can remove the else: altogether. |
swh/web/ui/service.py | ||
---|---|---|
236 ↗ | (On Diff #216) | That's a good point ^^ |