Page MenuHomeSoftware Heritage

Vagrantfile: Factorize duplication
ClosedPublic

Authored by ardumont on May 20 2021, 12:25 PM.

Details

Summary

It's been in my head for a while so here it goes ;)

It's currently quite difficult to maintain and we are duplicating too much.
This centralizes the vm information into one hashmap and then build the vm declaration out of it.

Test Plan

vagrant <action> <node> still works as before.

Diff Detail

Repository
rSENV Puppet Environment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.

Transfer remaining data into the main hashmap.

ardumont edited the test plan for this revision. (Show Details)

great simplification ! thanks

This revision is now accepted and ready to land.May 20 2021, 3:20 PM