Page MenuHomeSoftware Heritage

postgresql/client: Fix redundant user entry setup
ClosedPublic

Authored by ardumont on Thu, Apr 1, 11:43 AM.

Details

Summary

Those were unused, only the last hard-coded entry guest was used (as initially meant).

Test Plan

octocatalog-diff for a bunch of machines and no changes as expected
(somerset, belvedere, db1.staging, worker0.staging, ...)

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.

Is the user not used for the creation of the pgpass file ?

https://forge.softwareheritage.org/source/puppet-swh-site/browse/production/site-modules/profile/manifests/postgresql/client.pp$10
https://forge.softwareheritage.org/source/puppet-swh-site/browse/production/site-modules/profile/templates/postgres/pgpass.conf.erb$5

It is. But here, i just dropped the first entry user (there were 2, the last one being used in the "guest" entries).

The "admin" entries are touched only to push down the "user" configuration key entry down (to be symmetric with the guest part).

data/common/common.yaml
2997

@vsellier redundant because...

2999

...redefined here ^

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Apr 1, 4:51 PM
This revision was automatically updated to reflect the committed changes.