Differential D4831

hedgedoc: Fix reverse proxy configuration
ClosedPublic
Actions

Authored by ardumont on Jan 8 2021, 6:26 PM.

Details

Reviewers

vsellier

Group Reviewers

System administrators

Maniphest Tasks

T2935: Create reverse proxy for admin sites

Commits

rSPSITE6cc2dfc53842: varnish: Add websocket support
rSPSITEc51cbf9bb570: varnish/vhost: Use dash separators in x-forwarded-proto header
rSPSITE99e87889fca1: hedgedoc: Drop unneeded empty configuration

Summary

varnish/vhost: Use dash separators in x-forwarded-proto header (actually blocking)

expressjs backend engine does not agree with the _ separated version. Apparently,
current other backends seem somewhat ok with the existing versions though.

varnish: Add websocket support (hedgedoc frontend needs it)

hedgedoc: Drop unneeded empty configuration (more cosmetic than anything)

Related to T2935

Test Plan

vagrant up admin-bardo
vagrant up admin-rp1

we can now have a full (still anonymous or registered via email) edition (without the wheel of death ;)

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont requested review of this revision.Jan 8 2021, 6:26 PM

ardumont created this revision.

Harbormaster completed remote builds in B18254: Diff 17112.Jan 8 2021, 6:26 PM

ardumont edited the summary of this revision. (Show Details)Jan 8 2021, 6:47 PM

LGTM

This revision is now accepted and ready to land.Jan 11 2021, 9:49 AM

Closed by commit rSPSITE99e87889fca1: hedgedoc: Drop unneeded empty configuration (authored by ardumont). · Explain WhyJan 11 2021, 9:51 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rSPSITE99e87889fca1: hedgedoc: Drop unneeded empty configuration.

ardumont added a commit: rSPSITEc51cbf9bb570: varnish/vhost: Use dash separators in x-forwarded-proto header.

ardumont added a commit: rSPSITE6cc2dfc53842: varnish: Add websocket support.

Revision Contents
Changeset List

Path

Size

site-modules/

profile/

templates/

hedgedoc/

config.json.erb

2 lines

Diff 17122

View Options

site-modules/profile/templates/hedgedoc/config.json.erb

hedgedoc: Fix reverse proxy configurationClosedPublicActions