Page MenuHomeSoftware Heritage

Factorize the firewall properties
ClosedPublic

Authored by vsellier on Mon, Nov 16, 3:59 PM.

Details

Summary

The ip address is needed for the dns configuration and the icinga
tests, so the properties declarations needed to be refactored to
avoid duplicates

Related to T2755

Test Plan

octocatlog-diff for pergamon :

diff origin/production/pergamon.softwareheritage.org current/pergamon.softwareheritage.org
*******************************************
  Concat::Fragment[icinga2::object::Host::glyptotek.internal.softwareheritage.org] =>
   parameters =>
     content =>
      @@ -1,4 +1,5 @@
      _
       object Host "glyptotek.internal.softwareheritage.org" {
      +  address = "192.168.100.128"
         display_name = "glyptotek.internal.softwareheritage.org"
         check_command = "hostalive"
*******************************************
  Concat::Fragment[icinga2::object::Host::pushkin.internal.softwareheritage.org] =>
   parameters =>
     content =>
      @@ -1,4 +1,5 @@
      _
       object Host "pushkin.internal.softwareheritage.org" {
      +  address = "192.168.100.129"
         display_name = "pushkin.internal.softwareheritage.org"
         check_command = "hostalive"
*******************************************
  Concat_fragment[icinga2::object::Host::glyptotek.internal.softwareheritage.org] =>
   parameters =>
     content =>
      @@ -1,4 +1,5 @@
      _
       object Host "glyptotek.internal.softwareheritage.org" {
      +  address = "192.168.100.128"
         display_name = "glyptotek.internal.softwareheritage.org"
         check_command = "hostalive"
*******************************************
  Concat_fragment[icinga2::object::Host::pushkin.internal.softwareheritage.org] =>
   parameters =>
     content =>
      @@ -1,4 +1,5 @@
      _
       object Host "pushkin.internal.softwareheritage.org" {
      +  address = "192.168.100.129"
         display_name = "pushkin.internal.softwareheritage.org"
         check_command = "hostalive"
*******************************************
  Icinga2::Object::Host[glyptotek.internal.softwareheritage.org] =>
   parameters =>
     address =>
      + 192.168.100.128
*******************************************
  Icinga2::Object::Host[pushkin.internal.softwareheritage.org] =>
   parameters =>
     address =>
      + 192.168.100.129
*******************************************
  Icinga2::Object[icinga2::object::Host::glyptotek.internal.softwareheritage.org] =>
   parameters =>
     attrs =>
       address =>
        + 192.168.100.128
*******************************************
  Icinga2::Object[icinga2::object::Host::pushkin.internal.softwareheritage.org] =>
   parameters =>
     attrs =>
       address =>
        + 192.168.100.129
*******************************************
*** End octocatalog-diff on pergamon.softwareheritage.org

Diff Detail

Repository
rSPSITE puppet-swh-site
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier created this revision.Mon, Nov 16, 3:59 PM
vsellier updated this revision to Diff 15903.Mon, Nov 16, 4:03 PM

replace the lost lookup by an alias

ardumont accepted this revision.Mon, Nov 16, 4:04 PM
ardumont added a subscriber: ardumont.

lgtm!

and til about the path resolution with ., neat stuff.

2 typos inline ;)

data/common/common.yaml
959–960

alias

site-modules/profile/manifests/opnsense/monitoring.pp
11

fqdn =

This revision is now accepted and ready to land.Mon, Nov 16, 4:04 PM
vsellier updated this revision to Diff 15904.Mon, Nov 16, 4:07 PM

fix formating

This revision was automatically updated to reflect the committed changes.