Differential D4423

main: Define custom facts puppet needs to run
ClosedPublic
Actions

Authored by ardumont on Nov 6 2020, 10:08 AM.

Details

Reviewers

vsellier

Group Reviewers

System administrators

Maniphest Tasks

T2747: Create the reverse proxy to expose the staging services publicly

Commits

rSPREb591b57db6f0: terraform/modules/node/main: Define custom facts puppet needs to run

Summary

They used to be installed in the template. We now inline those directly prior
to the puppet step run (as it's a puppet requisite so it installs correctly the roles)

Related to T2747

Test Plan

terraform plan and apply happy, new rp0 got created with this

Diff Detail

Repository

rSPRE sysadm-provisioning

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Nov 6 2020, 10:08 AM

Harbormaster completed remote builds in B16886: Diff 15665.Nov 6 2020, 10:08 AM

ardumont edited the summary of this revision. (Show Details)Nov 6 2020, 10:13 AM

LGTM

This revision is now accepted and ready to land.Nov 6 2020, 10:15 AM

Closed by commit rSPREb591b57db6f0: terraform/modules/node/main: Define custom facts puppet needs to run (authored by ardumont). · Explain WhyNov 6 2020, 10:17 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rSPREb591b57db6f0: terraform/modules/node/main: Define custom facts puppet needs to run.

Revision Contents
Changeset List

Path

Size

proxmox/

terraform/

modules/

node/

main.tf

17 lines

variables.tf

12 lines

Diff 15670

View Options

proxmox/terraform/modules/node/main.tf