Page MenuHomeSoftware Heritage

add swh-hg-identfy a cli to identify hg objects
AbandonedPublic

Authored by acezar on Oct 14 2020, 7:47 PM.

Details

Reviewers
None
Group Reviewers
Reviewers

Diff Detail

Repository
rDLDHG Mercurial loader
Branch
identify
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16291
Build 25073: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 25072: arc lint + arc unit

Event Timeline

It seems you are struggling with the CI both in the previous diff and this one.

Build has FAILED

According to the build failure (and the previous diff's), the ci does not find
your diff's commit content [1] (in the staging area, location where diff are
pushed in phabricator). Given that this persists across diffs, I'd say the
problem must lie with your arcanist setup.

When the setup is ok, you should see when arc diffing, PUSH STAGING within
your arc diff command output. I've attached a full sample [2].

If the setup is not ok (or, tbf, if the repository is not configured to use
staging, loader-mercurial is), I gather you should see something like `SKIP
STAGING` (hopefully with an explanation...). Can you please check that?

It'd be worth it to check again if your phabricator setup is ok [3]?

In that regards, I'd check:

  • the git remote url, is it https? or ssh://git?
  • do you have your ~/.gitconfig setup ok [4]
  • is your ssh key (ssh agent) correctly configured?

Note: fwiw, given that your issue persists here, it'd be more easy for your
initial reviewer @marmoute that you fix first your setup. When that's done
(hopefully you will eventually find out), then continue your work on the
previous/original diff (to reopen it, simply arc diff --update it).

[1]

fatal: Couldn't find remote ref refs/tags/phabricator/diff/15064

[2]

$ ~/bin/arc diff HEAD~ --update D4256
+ export 'EDITOR=/home/tony/bin/emacs -nw'
+ EDITOR='/home/tony/bin/emacs -nw'
+ /nix/store/09rjs5sz5jdd9wmz00i9p3p9z2m83g5p-arcanist-20200127/bin/arc diff HEAD~ --update D4256
+ /nix/store/733vncig2mn6nbvzdxndj6d06qdy6syl-emacs-26.3/bin/emacsclient --create-frame -nw /tmp/edit.23qnhgljm8lc04w8/differential-update-comments
Linting...
No lint engine configured for this project.
Running unit tests...
No unit test engine is configured for this project.
 PUSH STAGING  Pushing changes to staging area...
Enumerating objects: 17, done.
Counting objects: 100% (17/17), done.
Delta compression using up to 8 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 2.80 KiB | 573.00 KiB/s, done.
Total 9 (delta 6), reused 0 (delta 0)
To forge.softwareheritage.org:/source/staging.git
 * [new tag]         acf202c5bb810f5700f1a317b72b8d2734f47c49 -> phabricator/base/15034
 * [new tag]         588d6a3a5d9e896c303439d6dcf70172991ad2b9 -> phabricator/diff/15034
Updated an existing Differential revision:
        Revision URI: https://forge.softwareheritage.org/D4256

Included changes:
  M       swh/deposit/cli/admin.py
  M       swh/deposit/tests/cli/test_admin.py

[3] https://wiki.softwareheritage.org/wiki/Code_review_in_Phabricator#Enabling_git_push_to_our_forge

[4] https://wiki.softwareheritage.org/wiki/Code_review_in_Phabricator#SSH_key_for_pushes

Hope this helps,

D4216 has been fixed so this diff is obsolete