Page MenuHomeSoftware Heritage

Define apt keys as files
AbandonedPublic

Authored by ardumont on Thu, Apr 30, 5:06 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary
  • jobs/templates/debian: Create "keys" folders out of a template directory
  • jobs/templates/debian: Remove unnecessary (<- maybe?) read/write operations
  • jobs/templates/debian: Add wrapping ls command to ensure it works

This to allow a simple update of apt keys later on (the current need is to
update the cassandra apt keys)

Test Plan

tox

Well and then aside pushing and installing this on jenkins, i don't know how to check that it actually works...

Diff Detail

Repository
rCJSWH Jenkins jobs
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12226
Build 18541: arc lint + arc unit

Event Timeline

ardumont created this revision.Thu, Apr 30, 5:06 PM
ardumont added inline comments.Thu, Apr 30, 5:11 PM
jobs/templates/debian/gbp-buildpackage.groovy.j2
84

i don't know if i actually need to do the side-effects of writing the files or not...

among the commits of that diff, i removed the following side-effect actions (but that might be required?)

-          writeFile(
-            file: 'ceph.asc',
-            text: new File('./keys/ceph.asc').text
-          )
-          // wget https://www.postgresql.org/media/keys/ACCC4CF8.asc
-          writeFile(
-            file: 'postgres.asc',
-            text: new File('./keys/postgres.asc').text
-          )
-          // wget https://artifacts.elastic.co/GPG-KEY-elasticsearch
-          writeFile(
-            file: 'elasticsearch.asc',
-            text: new File('./keys/elasticsearch.asc').text
-          )
-          // wget https://www.apache.org/dist/cassandra/KEYS
-          writeFile(
-            file: 'cassandra.asc',
-            text: new File('./keys/cassandra.asc').text
-         )
ardumont edited the summary of this revision. (Show Details)Thu, Apr 30, 5:12 PM
ardumont edited the test plan for this revision. (Show Details)
ardumont abandoned this revision.Thu, Apr 30, 5:25 PM

will do some refactoring later.