Differential D2028

[wip] package-loader: Implement a common package loader mechanism
ClosedPublic
Actions

Authored by ardumont on Sep 24 2019, 10:05 AM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDLDBASE76c93a66371b: package.loaders: Fix type checking warnings
rDLDBASEb316d36f5d48: loader: Deal with loading error

Summary

This also demonstrate the following reimplementation of:

gnu
pypi
npm (not yet)

Note:

This will get split into multiple diffs.
This will also probably get moved out of swh-loader-core.
In the mean time, to demonstrate progress has been done, here is the wip diff.
Also, this allows to check everything is fine regarding the ci

Related T1389

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 24 2019, 10:05 AM

ardumont planned changes to this revision.Sep 24 2019, 10:06 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/165/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/165/console

Harbormaster failed remote builds in B7922: Diff 6808!Sep 24 2019, 10:06 AM

ardumont retitled this revision from package-loader: Implement a common package loader mechanism to [wip] package-loader: Implement a common package loader mechanism.Sep 24 2019, 10:06 AM

ardumont edited the summary of this revision. (Show Details)

ardumont edited the summary of this revision. (Show Details)Sep 24 2019, 10:08 AM

ardumont added projects: Core Loader, Origin-GNU, PyPI loader, Npm loader.

This revision was not accepted when it landed; it landed in state Changes Planned.Sep 24 2019, 2:37 PM

This revision was landed with ongoing or failed builds.

Closed by commit rDLDBASEb316d36f5d48: loader: Deal with loading error (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASEb316d36f5d48: loader: Deal with loading error.

ardumont added a commit: rDLDBASE76c93a66371b: package.loaders: Fix type checking warnings.

roh, i did not want to close it...
I just wanted to update the diff... oh, well!

Revision Contents
Changeset List

Path

Size

swh/

loader/

package/

loader.py

199 lines

tests/

test_gnu.py

53 lines

Diff 6821

View Options

swh/loader/package/loader.py