Page MenuHomeSoftware Heritage
Differential D1701

Add tests for the in-mem storage with origin ids disabled.
ClosedPublic
Actions

Authored by vlorentz on Jul 9 2019, 3:02 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Commits
rDSTOCc36b6c315056: Add tests for the in-mem storage with origin ids disabled.
Summary

I forgot to write tests for D1690...

Test Plan

They are run by tox by default (don't worry about CI run times, they only take a few seconds)

Diff Detail

Repository
rDSTOC swh-storage-cassandra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 9 2019, 3:02 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 9 2019, 3:02 PM
vlorentz added inline comments.Jul 9 2019, 3:03 PM
swh/storage/tests/test_storage.py
1554–1556

note that I dropped these three lines [...]

1562–1564

[...] and these three, because they are duplicates of lines above.

vlorentz edited the test plan for this revision. (Show Details)Jul 9 2019, 3:04 PM
swh-public-ci added a comment.Jul 9 2019, 3:06 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/550/ for more details.

Harbormaster completed remote builds in B6732: Diff 5710.Jul 9 2019, 3:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 9 2019, 3:07 PM
Closed by commit rDSTOCc36b6c315056: Add tests for the in-mem storage with origin ids disabled. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz mentioned this in D1717: Add tests for the in-mem storage with origin ids disabled..Jul 10 2019, 4:15 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
3 lines
tests/
24 lines
250 lines
11 lines

Diff 5711

View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/tests/test_in_memory.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal